Skip to content

Conversation

@iluise
Copy link
Collaborator

@iluise iluise commented Dec 1, 2025

Description

Fix the conflict in eccodes versions after: https://github.com/ecmwf/WeatherGenerator/pull/1377/files#diff-823bfaf6136c1cb8dab18e972792cb0c79666cd9f22415063678125953083b3a

Issue Number

Closes #1376
Closes #1312

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@iluise iluise self-assigned this Dec 1, 2025
@iluise iluise added the eval anything related to the model evaluation pipeline label Dec 1, 2025
Copy link
Collaborator

@tjhunter tjhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iluise I have one comment. You can address it and merge without further review on my side. Thanks for going through the process!

@iluise iluise merged commit 010da5a into develop Dec 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

hot fixes for the evaluation package problem with eccode when running the export script on Santis

3 participants