feat: add CycleIntervalProvider and set_start_step_to_zero patch#564
Open
floriankrb wants to merge 5 commits intomainfrom
Open
feat: add CycleIntervalProvider and set_start_step_to_zero patch#564floriankrb wants to merge 5 commits intomainfrom
floriankrb wants to merge 5 commits intomainfrom
Conversation
- New CycleIntervalProvider class for defining accumulation intervals based on repeating cycles (e.g. operational forecast schedules) - Register it in the interval generator factory under 'cycle' key - Add set_start_step_to_zero patch in field_to_interval for data with wrongly encoded start_step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
CycleIntervalProviderfor defining accumulation intervals based on repeating cycles (e.g. operational forecast schedules).CycleIntervalProviderclass ininterval_generators.pycyclekeyset_start_step_to_zeropatch infield_to_interval.pyfor data with wrongly encoded start_stepThis CycleIntervalProvider may not how we can support forecast datata, it has the very strong limitation that it cannot support multiple data for the same valid date.
We may not want to keep it very long, but it is a hacky way to give fine control over how to build accumulations with forecast data.
Split from #545.