Skip to content

Calling set without args should return the field itself #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandorkertesz merged 1 commit into from
Mar 11, 2026
Merged

Calling set without args should return the field itself #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/earthkit/data/core/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,10 @@ def set(self, *args, **kwargs):
raise ValueError(f"Cannot use arg={a}. Only dict allowed.")

_kwargs = defaultdict(dict)

if not kwargs:
return self

_components = dict()
for k, v in kwargs.items():
if k in self._components:
Expand Down
16 changes: 12 additions & 4 deletions tests/grib/test_grib_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
from grib_fixtures import load_grib_data # noqa: E402


# @pytest.mark.parametrize("fl_type", ["file", "array", "memory"])
@pytest.mark.parametrize("fl_type", ["file"])
@pytest.mark.parametrize("fl_type", ["file", "array", "memory"])
# @pytest.mark.parametrize("fl_type", ["file"])
def test_grib_set_detailed(fl_type):
ds_ori, _ = load_grib_data("test4.grib", fl_type)

Expand Down Expand Up @@ -166,8 +166,7 @@ def test_grib_set_detailed(fl_type):
# assert ds_1.metadata("levelist") == [600, 600]x


# @pytest.mark.parametrize("fl_type", ["file", "array", "memory"])
@pytest.mark.parametrize("fl_type", ["file"])
@pytest.mark.parametrize("fl_type", ["file", "array", "memory"])
def test_grib_set_combined(fl_type):
ds_ori, _ = load_grib_data("test4.grib", fl_type)

Expand Down Expand Up @@ -435,3 +434,12 @@ def test_grib_copy_to_field(fl_type):
assert ds_saved.get("levelist") == [600, 600]
assert np.allclose(ds_saved[0].values, vals_ori + 1)
assert np.allclose(ds_saved[1].values, vals_ori + 2)


@pytest.mark.parametrize("fl_type", ["file"])
def test_grib_set_no_args(fl_type):
ds, _ = load_grib_data("test4.grib", fl_type)

f = ds[0]
r = f.set()
assert r is f
Loading