Open
Conversation
marcosbento
force-pushed
the
improvement/add_build_type_minsizerel
branch
from
083b6d8 to
a0de359
Compare
wdeconinck
approved these changes
Mar 16, 2026
Member
wdeconinck
left a comment
wdeconinck
left a comment
There was a problem hiding this comment.
For other build types we have default flags, which will not be added here because this build type is not added there. I guess the point of this build type is anyway not best performance on HPC, so OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add MinSizeRel as valid CMAKE_BUILD_TYPE -- implements the #130.
Contributor Declaration
By opening this pull request, I affirm the following: