Revert CMAKE_NO_SYSTEM_FROM_IMPORTED to CMake default#133
Open
marcosbento wants to merge 1 commit intodevelopfrom
Open
Revert CMAKE_NO_SYSTEM_FROM_IMPORTED to CMake default#133marcosbento wants to merge 1 commit intodevelopfrom
marcosbento wants to merge 1 commit intodevelopfrom
Conversation
CMAKE_NO_SYSTEM_FROM_IMPORTED controls the use of system (--isystem) vs non-system (-I) include directories for imported targets, such as those found via `find_package`. See https://cmake.org/cmake/help/latest/variable/CMAKE_NO_SYSTEM_FROM_IMPORTED.html The default value of CMAKE_NO_SYSTEM_FROM_IMPORTED is OFF, meaning that system include directories are used for imported targets.
There was a problem hiding this comment.
Pull request overview
This PR reverts an ecbuild-level override of CMAKE_NO_SYSTEM_FROM_IMPORTED so that ecbuild uses CMake’s default behavior (OFF), causing include directories from imported targets (e.g., via find_package) to be treated as system include paths.
Changes:
- Removed the explicit
set(CMAKE_NO_SYSTEM_FROM_IMPORTED ON)from ecbuild’s option initialization. - Restored CMake default handling for imported target include directories (system vs non-system).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CMAKE_NO_SYSTEM_FROM_IMPORTED controls the use of system (--isystem) vs non-system (-I) include directories for imported targets, such as those found via
find_package.See https://cmake.org/cmake/help/latest/variable/CMAKE_NO_SYSTEM_FROM_IMPORTED.html
This change ensures the use of the default value of CMAKE_NO_SYSTEM_FROM_IMPORTED (i.e. OFF),
meaning that system include directories are used for imported targets.
Contributor Declaration
By opening this pull request, I affirm the following: