Skip to content

Conversation

dsarmany
Copy link
Collaborator

@dsarmany dsarmany commented Oct 8, 2025

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-173

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.60%. Comparing base (65c09cd) to head (4f60b3b).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/multio/datamod/types/Repres.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #173   +/-   ##
========================================
  Coverage    56.60%   56.60%           
========================================
  Files          316      316           
  Lines        20490    20490           
  Branches      1569     1569           
========================================
  Hits         11598    11598           
  Misses        8892     8892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsarmany dsarmany force-pushed the feature/regularll-in-encoder-mtg2 branch from 53d0b79 to e050ff2 Compare October 8, 2025 15:26
@pgeier pgeier force-pushed the feature/regularll-in-encoder-mtg2 branch from e050ff2 to 4d1b2b0 Compare October 9, 2025 09:50
@pgeier
Copy link
Contributor

pgeier commented Oct 10, 2025

The debug log message has been removed.

Grib1-to-grib2 files have been compared (bit-equal).

Just waiting for the ERA6-LWDA - but I don't expect differences here. The fdb-compare needs updates, that's why I am blocked.

Otherwise this can be merged.

pgeier
pgeier previously approved these changes Oct 10, 2025
@pgeier pgeier force-pushed the feature/regularll-in-encoder-mtg2 branch from 4d1b2b0 to d251855 Compare October 10, 2025 09:16
@dsarmany dsarmany dismissed stale reviews from MircoValentiniECMWF and pgeier October 10, 2025 14:10

The merge-base changed after approval.

@dsarmany dsarmany force-pushed the feature/regularll-in-encoder-mtg2 branch from d251855 to 977a502 Compare October 10, 2025 14:21
@dsarmany dsarmany force-pushed the feature/regularll-in-encoder-mtg2 branch from 977a502 to 4f60b3b Compare October 10, 2025 15:13
@dsarmany dsarmany merged commit 9417ccb into develop Oct 10, 2025
132 of 134 checks passed
@dsarmany dsarmany deleted the feature/regularll-in-encoder-mtg2 branch October 10, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants