Merged
Conversation
87f9476 to
884512d
Compare
344fe4a to
ccb6d49
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reduces logging verbosity by changing numerous logging.info() calls to logging.debug() for routine operational messages, removes some verbose logging statements entirely, and introduces security improvements by obfuscating API keys and tokens in logs. It also refactors subprocess output handling to use buffering instead of immediate line-by-line logging, and adds a caching decorator to the authentication method to improve performance.
Changes:
- Downgraded logging levels from info to debug for routine operational status updates across worker, datasource, request, staging, and metric components
- Added API key obfuscation when logging environment variables and MARS credentials
- Refactored subprocess output handling to use buffering with new helper methods
- Added 60-second caching to authotron.authenticate method
- Added optional logging parameter to RequestAccepted response handler
- Removed unused check_extra_roles method from polytope datasource
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| polytope_server/worker/worker.py | Changed logging levels to debug and removed verbose worker status logging block |
| polytope_server/frontend/common/flask_decorators.py | Added optional info_log parameter to RequestAccepted to allow debug-level logging |
| polytope_server/frontend/common/data_transfer.py | Used new optional logging parameter to reduce verbosity for query requests |
| polytope_server/common/user.py | Changed authorization success logging to debug level |
| polytope_server/common/subprocess.py | Major refactoring: added buffering for output, obfuscated API keys in env logging, fixed env parameter handling |
| polytope_server/common/staging/s3_staging.py | Changed bucket initialization logging to debug level |
| polytope_server/common/request.py | Changed request status update logging to debug level |
| polytope_server/common/metric_calculator/mongo.py | Changed metric calculator initialization and index creation logging to debug level |
| polytope_server/common/logging.py | Changed logging initialization message to debug level |
| polytope_server/common/io/fifo.py | Changed FIFO creation logging to debug level |
| polytope_server/common/datasource/polytope.py | Removed unused check_extra_roles method and changed result retrieval logging to debug |
| polytope_server/common/datasource/mars.py | Changed various MARS operation logs to debug and added API key obfuscation |
| polytope_server/common/datasource/datasource.py | Changed datasource initialization logging to debug level |
| polytope_server/common/authotron.py | Added cache decorator and changed authentication logging to debug level |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: