Merge Testing #81
Merged
Merge Testing #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design: studentsCanSeeStatistics: true
studentsCanSeeStatistic: true
Revert "studentsCanSeeStatistic: true"
…r-compose for production serving. Fixed bugs that only occured when running inside docker.
This reverts commit 257c039.
This reverts commit 11d1209.
This reverts commit 3923ba6.
…ed docker-compose for production serving. Fixed bugs that only occured when running inside docker." This reverts commit 1d32821.
* Added dockerfiles for frontend and backend containers. Adjusted docker-compose for production serving. Fixed bugs that only occured when running inside docker. * Added missing entry MONGODB_HOST * Create .env * Update .env.template * Delete packages/frontend/.env The variables are now in docker/.env-production * Update docker-compose.prod.yaml Typo (I think...) --------- Co-authored-by: Hendrik Belitz <[email protected]>
Removes hard-coded internal API key
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Container.set<string[]>("api-keys", process.env.API_KEYS?.split(",") ?? []); | ||
| Container.set<string[]>( | ||
| "api-keys", | ||
| process.env.API_KEYS?.split(",") ?? ["25868755-c11c-42ee-b4ed-2115ac982ba4"] |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.