Skip to content

2435 check plugin name #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

2435 check plugin name #18

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5ed4b76
Allow arbitrary length filenames in repositories (#5771)
meineerde Jul 5, 2010
75d5ab4
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Jul 6, 2010
89cb1b9
Force the default value of path to be set on the Change model class. …
meineerde Jul 6, 2010
e275adf
Merge branch 'master' of git://github.com/edavis9/redmine
meineerde Jul 27, 2010
623c60d
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 3, 2010
f8025ec
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 8, 2010
59905a2
Force the default value of path to be set on the Change model class. …
meineerde Jul 6, 2010
fb864e5
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 11, 2010
f07e578
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 11, 2010
961bbc1
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 31, 2010
ad100cc
Merge branch 'master' of git://github.com/edavis10/redmine
meineerde Aug 31, 2010
132ece8
First version of plugin name check
meineerde Aug 31, 2010
ee69f9a
Use a deprecation warning instead
meineerde Aug 31, 2010
77d8496
More verbose errors. Include timebomb for transition from deprecation…
meineerde Aug 31, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/redmine/plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ def def_field(*names)

# Plugin constructor
def self.register(id, &block)
# check if the plugin is in the correct location
unless Engines.plugins.collect(&:name).include? id
if Redmine::VERSION::MAJOR <= 1 && Redmine::VERSION::MINOR < 1
ActiveSupport::Deprecation.warn "WARNING: The #{id} plugin needs to be inside #{File.join(RAILS_ROOT, 'vendor', 'plugins', id.to_s)}"
else
raise "ERROR: The #{id} plugin needs to be inside #{File.join(RAILS_ROOT, 'vendor', 'plugins', id.to_s)}"
end
end

p = new(id)
p.instance_eval(&block)
# Set a default name if it was not provided during registration
Expand Down