Skip to content

Ný útgáfa af hoverrole, fyrir íðorðabankann #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benediktmag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ný útgáfa af hoverrole, fyrir íðorðabankann #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- sphinxcontrib-custombutton @ https://github.com/edbook/sphinxcontrib-custombutton/archive/refs/tags/v2.0.zip
- sphinxcontrib-datacamp @ https://github.com/edbook/sphinxcontrib-datacamp/archive/refs/tags/v2.0.zip
- sphinxcontrib-geogebra @ https://github.com/edbook/sphinxcontrib-geogebra/archive/refs/tags/v2.0.zip
- sphinxcontrib-hoverrole @ https://github.com/edbook/sphinxcontrib-hoverrole/archive/refs/tags/v2.0.15.zip
- sphinxcontrib-hoverrole @ https://github.com/edbook/sphinxcontrib-hoverrole/archive/refs/tags/v2.5.0.zip
- sphinxcontrib-panopto @ https://github.com/edbook/sphinxcontrib-panopto/archive/refs/tags/v2.0.1.zip
- sphinxcontrib-questionnaire @ https://github.com/edbook/sphinxcontrib-questionnaire/archive/refs/tags/v2.0.9.zip
- sphinxcontrib-sagecell @ https://github.com/edbook/sphinxcontrib-sagecell/archive/refs/tags/v2.0.zip
Expand Down
1 change: 1 addition & 0 deletions projects/byg302g/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
extensions.append('sphinxcontrib.bibtex')
extensions.remove('sphinxcontrib.hoverrole')
bibtex_bibfiles = ['refs.bib']

8 changes: 5 additions & 3 deletions projects/byg302g/kafli01.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ pússningu og fylliefni en þessi efni eru alls 3322 kg/m2 íbúðarrýmis.
Gagnlegur orðskýringalisti: https://www.princeton.edu/~maelabs/mae324/glos324/index.htm


Heimildir
---------
.. bibliography::

..
Heimildir
.. bibliography::

Comment on lines +88 to +91

@coderabbitai coderabbitai Bot Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix RST comment syntax and ensure consistency
The “Heimildir” section and .. bibliography:: are currently under an indented .. block, which will not properly disable rendering. In reStructuredText, each commented line must start with .. (two dots and a space). Also, other chapters remove this section entirely rather than commenting it out.

Either remove the lines or prefix each line properly:

- .. 
-    Heimildir
-    .. bibliography::
+ .. Heimildir
+ .. bibliography::

Alternatively, delete these lines to match the approach in other chapters.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
..
Heimildir
.. bibliography::
.. Heimildir
.. bibliography::
🤖 Prompt for AI Agents 
In projects/byg302g/kafli01.rst around lines 88 to 91, the "Heimildir" section
and the `.. bibliography::` directive are incorrectly placed inside an indented
`..` block, which does not properly comment them out in reStructuredText. To fix
this, either remove these lines entirely to be consistent with other chapters or
prefix each line with `.. ` (two dots and a space) to correctly comment them out
and prevent rendering.

5 changes: 1 addition & 4 deletions projects/byg302g/kafli02.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ Jónabindingar
:height: 400

Kóvalentbindingar
~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~

.. figure:: ./myndir/kafli02/kovalentbinding.png
:align: center
Expand Down Expand Up @@ -421,6 +421,3 @@ Dæmi;

* Alkalí-kísil gel

Heimildir
---------
.. bibliography::
11 changes: 4 additions & 7 deletions projects/byg302g/kafli04.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Varmaflutningur getur verið eftir þrem leiðum;
.. figure:: ./myndir/kafli04/varmaflutningsleidir.png
:align: center
:width: 100%

Mynd 4.1. Mynd fengin úr :cite:`1978:Halldorsson`

.. youtube:: Eizsm5V8c_c
Expand Down Expand Up @@ -460,15 +461,15 @@ Leiðnitala efnis er mæld með þrennu móti;
:align: center
:width: 85%

2. Hitafall yfir mælisýni og þekkt viðmiðunarsýni mælt
2. Hitafall yfir mælisýni og þekkt viðmiðunarsýni mælt.

Eitt sýni mælt – og þá skiptir máli í hvaða átt varmaflutningurinn er! Uppbyggingin er:

.. figure:: ./myndir/kafli04/Uppbygging2.png
:align: center
:width: 100%

3. Varmaflutningur í gegnum sýnið mældur (þetta er keimlíkt og í lið b). Eitt sýni
mælt – og þá skiptir máli í hvaða átt varmaflutningurinn er! Uppbyggingin er:
3. Varmaflutningur í gegnum sýnið mældur (þetta er keimlíkt og í lið b). Eitt sýni mælt – og þá skiptir máli í hvaða átt varmaflutningurinn er! Uppbyggingin er:

.. figure:: ./myndir/kafli04/Uppbygging3.png
:align: center
Expand Down Expand Up @@ -533,7 +534,3 @@ Uppgefnar leiðnitölur algengra einangrunarefna
:width: 100%



Heimildir
---------
.. bibliography::
5 changes: 1 addition & 4 deletions projects/byg302g/kafli06.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ Aðrar línur fyrir prófun í tiltekinn dagafjölda og loks skriðmörkin við
4- fjórðungur sýnir tímaháð skrið fyrir gefna (sömu) spennu í efni

Þreyta (e. fatigue, d. udmattelse)
~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Þegar efni verður fyrir síendurteknu álagi (álagshrinum) þá getur slíkt framkallað
þreytubrot (þetta er almennt skýrt þannig að örsprungur (e. microcracks) séu til staðar í
Expand Down Expand Up @@ -530,6 +530,3 @@ Atriði sem hafa áhrif á mat á prófunarniðurstöðum
Raki skiptir alltaf verulegu máli þegar rakadræg efni eiga í hlut; efnisstyrkur og
stífleiki t.d. timburs er mjög háður efnisraka (sbr. umfjöllun um timbur síðar!).

Heimildir
---------
.. bibliography::
4 changes: 1 addition & 3 deletions projects/byg302g/kafli07.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ rakabreytingu úr “blautu” ástandi í þurrt (þ.e. :math:`\Delta u \approx
.. figure:: ./myndir/kafli07/rakabreytingfura.png
:align: center
:width: 50%

Myndin fengin úr Rb-blaði :cite:`2016:Sigurjonsson`

.. figure:: ./myndir/kafli07/rakabreytingsteypa.png
Expand All @@ -161,6 +162,3 @@ rakaþensla sé svipuð og rýrnunin á línuritinu 7.4

Plast hefur miklar rakahreyfingar.. og einnig miklar hitahreyfingar eins og áður getur.

Heimildir
---------
.. bibliography::
2 changes: 1 addition & 1 deletion projects/byg302g/kafli10.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ Seighersla (e. tempering)
Stýra eiginleikum enn frekar með endurupphitun (lægri hiti en við glæðingu) og hægri kælingu (þó hraðar en við glæðingu)
Hefur áhrif á hörku og seigju.

.. figure:: ./myndir/kafli10/Seighersla.png
.. figure:: ./myndir/kafli10/seighersla.png
:align: center
:width: 80%

Expand Down