fix: remove setup.py version bump that pushes to protected main - #232
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis PR simplifies the release workflow by removing the cli/setup.py version update step and consolidating the tag creation and push flow, reducing workflow complexity through the removal of unnecessary steps and permissions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The create-release job tried to commit a version bump to cli/setup.py and push directly to main, which fails because main has branch protection (requires PR + status checks). Removed the setup.py update and commit/push steps — the version is already captured in the git tag and release notes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d90b69d to
4c6f766
Compare
📚 PR Documentation DeployedYour PR documentation is available with enhanced build performance: 🔗 PR Documentation: https://edbook.github.io/haskoli-islands/fix/release-no-push-to-main/ ✨ Performance Features:
Version: |
Summary
Update setup.py versionandCommit version updatesteps fromcreate-releasejob inrelease.ymlpull-requests: writepermissionProblem
The
Create GitHub Releasejob failed because it tried togit pusha setup.py version bump directly to the protectedmainbranch. GitHub branch protection rejects direct pushes — changes must go through PRs with passing status checks.Error:
Fix
The version is already captured in the git tag and release notes, so the setup.py commit is unnecessary. Removing it avoids the protected branch conflict entirely.
Test plan
projects/**orcli/**🤖 Generated with Claude Code
Summary by CodeRabbit