Skip to content

fix: remove setup.py version bump that pushes to protected main - #232

Merged
busla merged 1 commit into
mainfrom
fix/release-no-push-to-main
Feb 13, 2026
Merged

fix: remove setup.py version bump that pushes to protected main#232
busla merged 1 commit into
mainfrom
fix/release-no-push-to-main

Conversation

@busla

@busla busla commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the Update setup.py version and Commit version update steps from create-release job in release.yml
  • Remove unnecessary pull-requests: write permission
  • Merge git config and tag creation into a single step

Problem

The Create GitHub Release job failed because it tried to git push a setup.py version bump directly to the protected main branch. GitHub branch protection rejects direct pushes — changes must go through PRs with passing status checks.

Error:

remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request.

Fix

The version is already captured in the git tag and release notes, so the setup.py commit is unnecessary. Removing it avoids the protected branch conflict entirely.

Test plan

  • Merge this PR, then push a content change to projects/** or cli/**
  • Verify the release workflow completes all 4 jobs: generate-version, build-docs, create-release, notify-discord

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Optimized the release workflow process by consolidating release steps and streamlining automation procedures.

@busla
busla had a problem deploying to fix/release-no-push-to-main February 13, 2026 21:05 — with GitHub Actions Error
@coderabbitai

coderabbitai Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

This PR simplifies the release workflow by removing the cli/setup.py version update step and consolidating the tag creation and push flow, reducing workflow complexity through the removal of unnecessary steps and permissions.

Changes

Cohort / File(s) Summary
GitHub Actions Release Workflow
.github/workflows/release.yml
Removed the cli/setup.py version update step and associated git commit/push operations. Eliminated the pull-requests permission from the create-release job. Consolidated tag creation and push flow by removing the separate "Create and push tag" block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • benediktmag
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/release-no-push-to-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The create-release job tried to commit a version bump to cli/setup.py
and push directly to main, which fails because main has branch
protection (requires PR + status checks).

Removed the setup.py update and commit/push steps — the version is
already captured in the git tag and release notes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@busla
busla force-pushed the fix/release-no-push-to-main branch from d90b69d to 4c6f766 Compare February 13, 2026 21:06
@busla
busla enabled auto-merge (squash) February 13, 2026 21:06
@busla
busla merged commit 0ecf8d3 into main Feb 13, 2026
1 check passed
@busla
busla deleted the fix/release-no-push-to-main branch February 13, 2026 21:07
@github-actions

Copy link
Copy Markdown

📚 PR Documentation Deployed

Your PR documentation is available with enhanced build performance:

🔗 PR Documentation: https://edbook.github.io/haskoli-islands/fix/release-no-push-to-main/
🔗 Individual Projects: Available at https://edbook.github.io/haskoli-islands/fix/release-no-push-to-main/[project-name]/

✨ Performance Features:

  • ⚡ Parallel builds (4x faster)
  • 💾 Intelligent caching
  • 🏗️ Optimized Sphinx configuration
  • 📊 Build statistics included

Version: 26.02.13.2107+9fdc792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant