Skip to content

feat: complete AGENT, INSTALL modules; promote ORCH to Ready#33

Merged
joshuaboys merged 13 commits into
mainfrom
dev
Apr 28, 2026
Merged

feat: complete AGENT, INSTALL modules; promote ORCH to Ready#33
joshuaboys merged 13 commits into
mainfrom
dev

Conversation

@joshuaboys
Copy link
Copy Markdown
Contributor

Summary

  • AGENT-006: Cross-harness testing complete. Fixed stale OpenCode model IDs, added Codex vendor comments, created test plan for all 5 tool harnesses.
  • INSTALL module (all 9 work items): Built aps init v2 with shell-prompt wizard, aps migrate for v1→v2 conversion, aps update v2-aware refresh, multi-tool support for 6 targets, config.yml generation, aps-rules-v2.md and project-context.md templates.
  • ORCH module: Resolved all 5 open decisions, added detail to work items, promoted from Draft to Ready.

Test plan

  • aps init --non-interactive produces correct .aps/ layout with config.yml
  • Multi-tool init (claude-code,codex,copilot) installs correct files per tool
  • aps migrate --dry-run previews v1→v2 changes without modifying files
  • aps migrate converts v1 layout cleanly (old dirs removed, hooks rewritten, backup created)
  • build.sh generates all 14 agent files, is idempotent
  • Agent format validation passes for all 5 harnesses
  • Interactive wizard flow (requires TTY)
  • Remote download mode (requires published branch)

🤖 Generated with Claude Code

joshuaboys and others added 6 commits March 16, 2026 11:40
Bring over architecture decisions, designs, module specs, research,
and reviews that represent current APS direction. Skipped 24 stale
files (completed specs, execution artifacts, templates already here).

Authored-By: Aneki (joshuaboys)
Add per-tool usage examples to agent docs (Claude Code, Copilot,
OpenCode, Codex, Gemini). Update onboarding design to reflect
architecture change from OpenTUI (Bun/Zig) to Rust/Ratatui. Mark
AGENT-005 complete.

APS: AGENT-005

Authored-By: Aneki (joshuaboys)
Update OpenCode model IDs from claude-opus-4-20250514 to claude-opus-4-6
and claude-sonnet-4-20250514 to claude-sonnet-4-6. Add vendor comments
to Codex o4-mini config. Create cross-harness test plan documenting
format validation and manual test procedures for all 5 tool harnesses.
Mark AGENT module as Complete.

authored-by: aneki (@joshuaboys)
…tion

Build the complete INSTALL module:
- aps init: 3-step shell-prompt wizard (profile, scope, AI tools) producing
  .aps/ layout with config.yml. Non-interactive fallback via flags.
- aps migrate: v1→v2 conversion with dry-run, file moves, backup to
  .aps/backup/, hook path rewriting, and config inference.
- aps update: v2-aware, reads config.yml to refresh tool-specific files.
- Multi-tool support for all 6 targets (Claude Code, Copilot, Codex,
  OpenCode, Gemini, generic) with correct file placement.
- New aps-rules-v2.md template (plans/designs/, project-context.md).
- New project-context.md template with TODO markers for agent bootstrap.
- APS_LOCAL env var for local development testing.

Mark all 9 INSTALL work items complete. Add decisions D-022 through D-025
to the index.

authored-by: aneki (@joshuaboys)
Resolve all 5 open decisions: coexist with TASKS (D-001), inline
learnings (D-002), advisory VCS only (D-003), TypeScript MCP server
(D-004), ephemeral context packages (D-005). Add confidence and
detailed validation to all work items. Promote from Draft to Ready.

authored-by: aneki (@joshuaboys)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1a519bd64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/scaffold.sh
Comment thread lib/scaffold.sh Outdated
Comment thread lib/scaffold.sh Outdated
- Install codex-config-snippet.toml during Codex scaffold so users can
  complete the documented merge step
- Use v2_install_cli/v2_install_scripts during migration instead of
  copying stale v1 binaries
- Remove only known APS files from lib/ during migration, preserving
  any non-APS project files that may coexist in the directory

authored-by: aneki (@joshuaboys)
@joshuaboys
Copy link
Copy Markdown
Contributor Author

Review Feedback Addressed

Code Changes (1 commit pushed)

  • Install codex-config-snippet.toml during Codex scaffold so users can complete the documented merge step (feedback from chatgpt-codex-connector)
  • Use v2_install_cli()/v2_install_scripts() during migration instead of copying stale v1 binaries (feedback from chatgpt-codex-connector)
  • Remove only known APS files from lib/ and bin/ during migration, preserving non-APS project files (feedback from chatgpt-codex-connector)

All 3 threads resolved.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09e0c1cb5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/scaffold.sh
Comment thread lib/scaffold.sh Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e312b9aac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/scaffold.sh Outdated
Comment thread lib/scaffold.sh Outdated
- Redirect prompt_select/prompt_multi display output to stderr so
  command substitution captures only the selection value
- Exit 1 (not 0) when cmd_migrate finds no v1 installation
- Strengthen is_v1_layout to require ≥2 APS markers, preventing
  false positives on repos with unrelated bin/aps
- Use cp -a designs/. to include dotfiles during migration

Authored-By: Aneki (joshuaboys)
@joshuaboys
Copy link
Copy Markdown
Contributor Author

Review Feedback Addressed

Code Changes (1 commit pushed)

  • Redirected prompt_select/prompt_multi display output to stderr so command substitution captures only the selection value (P1 feedback from chatgpt-codex-connector)
  • Split cmd_migrate exit paths: error case now exits 1, already-v2 case exits 0 (P2 feedback from chatgpt-codex-connector)
  • Strengthened is_v1_layout to require ≥2 of 5 APS-specific markers, preventing false-positive migration on non-APS repos (P1 feedback from chatgpt-codex-connector)
  • Changed cp -a designs/* to cp -a designs/. to include dotfiles during migration (P2 feedback from chatgpt-codex-connector)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a97a6da14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/scaffold.sh
Comment thread lib/scaffold.sh
- Back up existing aps-rules.md to .aps/backup/ before overwriting
  with v2 template
- Back up aps-planning/scripts/ to .aps/backup/scripts/ before
  removing the directory, preserving custom hook logic

Authored-By: Aneki (joshuaboys)
@joshuaboys
Copy link
Copy Markdown
Contributor Author

Review Feedback Addressed (round 2)

Code Changes (1 commit pushed)

  • Back up existing plans/aps-rules.md to .aps/backup/ before overwriting with v2 template (P1 feedback from chatgpt-codex-connector)
  • Back up aps-planning/scripts/ to .aps/backup/scripts/ before removing the directory, preserving custom hook logic (P2 feedback from chatgpt-codex-connector)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 126cefd427

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/scaffold.sh
# Update the updated timestamp
local today
today="$(date +%Y-%m-%d)"
sed -i "s/updated:.*/updated: \"$today\"/" "$target/.aps/config.yml"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace GNU-only sed -i with portable edit logic

cmd_update_v2 uses sed -i without a backup suffix, which works on GNU sed but fails on BSD/macOS sed (macOS requires -i '' ...). Because this line runs on every v2 aps update, macOS users hit a hard failure and the update aborts under set -e; the same non-portable pattern is also used in migration/path-update code paths, so this should be fixed with a portable in-place edit helper.

Useful? React with 👍 / 👎.

Customization frontend for APS project setup — replaces shell-prompt
wizard with granular Ratatui TUI wizard. Supports monorepo detection,
per-tool config, template/path customization, and config-driven init.

Decisions resolved: D-026 (cli/ in this repo), D-027 (git dep for
eddacraft-tui), D-028 (port lint to Rust for shared parser).

Authored-By: Aneki (joshuaboys)
- /plan now runs aps init if plans/ is missing
- /plan checks plans/.aps-version against current (0.2.0), runs aps update if behind
- aps init and aps update both write plans/.aps-version = 0.2.0
aps init now installs structure only (plans/, designs/, bin/aps, templates).
Skill/harness setup is an explicit opt-in via: aps setup <harness>
Supports claude-code, codex, opencode — TUI setup coming with TUI release.

Fixes: skill files no longer appear in every repo by default.
@joshuaboys joshuaboys merged commit e1c5e90 into main Apr 28, 2026
4 checks passed
joshuaboys added a commit that referenced this pull request Apr 28, 2026
- Redirect prompt_select/prompt_multi display output to stderr so
  command substitution captures only the selection value
- Exit 1 (not 0) when cmd_migrate finds no v1 installation
- Strengthen is_v1_layout to require ≥2 APS markers, preventing
  false positives on repos with unrelated bin/aps
- Use cp -a designs/. to include dotfiles during migration

Authored-By: Aneki (joshuaboys)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant