chore: public surface cleaning, add commit-msg guard#53
Merged
Conversation
Tier 1 (forward-facing polish): - README: remove duplicate Packages table and CLI Usage section - CHANGELOG: drop 'Comprehensive' qualifier - packages/kindling/README: move Anvil cross-product CTA out of the npm-visible top section into a Related footer - plans/specs/hearth: rephrase 'highest-leverage application of witchcraft' - .mailmap: unify 'aneki' display name to 'Josh Boys' Tier 2 (lock down going forward): - .husky/commit-msg: reject Co-Authored-By Claude trailers, claude.ai/code/session URLs, anthropic noreply addresses, and 'Generated with Claude Code' footers in commit messages - .github/workflows/no-ai-trailers.yml: same checks on every PR so the hook can't be silently bypassed Email consolidation and history rewrite are deliberately deferred to Tier 3.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes public-facing docs to reduce AI-provenance “tells” and adds enforcement to prevent AI-origin footers/trailers from entering commit history going forward.
Changes:
- Clean up and de-duplicate root README content; adjust package README/CHANGELOG wording and positioning of cross-product CTA.
- Rephrase and reformat a planning spec to remove odd phrasing and improve markdown consistency.
- Add a local
commit-msghook and a CI workflow to block commits containing specific AI-provenance trailers/URLs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes duplicate sections and updates the Packages table to the full/accurate list. |
| plans/specs/2026-05-01-hearth-rearchitecture.md | Markdown reformatting and wording cleanup in the Hearth rearchitecture spec. |
| packages/kindling/README.md | Moves Anvil CTA from top section to a bottom “Related” section. |
| CHANGELOG.md | Tweaks v0.1.0 wording (“Comprehensive test coverage” → “Test coverage”). |
| .mailmap | Adds author display-name normalization mappings. |
| .husky/commit-msg | Adds commit-message guard to block AI provenance footers/trailers/URLs. |
| .github/workflows/no-ai-trailers.yml | Adds CI job to reject PR commits containing AI provenance patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joshuaboys
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- no-ai-trailers workflow: drop unused 'violators' awk pass; lowercase patterns and normalise commit body before matching so case variants (Co-Authored-By / CO-AUTHORED-BY) all hit the same rule. - .mailmap: correct the format docstring — git's full form is <Proper Name> <proper email> <Commit Name> <commit email>, not the variant the previous comment described. - hearth spec: drop the AI-tooling branch reference from the metadata table, and fix the ember-*/edda-* markdown that was rendering as ember-_, edda-_ due to unescaped underscores.
Contributor
Author
Review Feedback AddressedCode Changes (1 commit pushed: 0716b68)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier 1 + 2 of the cleanup. Tier 3 is intentionally deferred.
Tier 1 — forward-facing polish
git log --use-mailmapand the GitHub UI show one consistent author. Email aliases are not consolidated yet — that's deliberately a Tier-3 decision.Tier 2 — lock down going forward
.husky/commit-msg: rejects commit messages containingCo-Authored-By: Claude*,claude.ai/code/session_*,noreply@anthropic.com, orGenerated with [Claude Code]/🤖 Generated withfooters. Override withCOMMIT_ALLOW_AI_TRAILERS=1if ever genuinely needed. Smoke-tested: clean messages pass; tells get blocked..github/workflows/no-ai-trailers.yml: same checks on every PR commit, so the local hook can't be silently bypassed by anyone — including future-you runninggit commit --no-verify.Test plan
pnpm run type-check(ran via pre-commit)no-ai-trailersjob, which should pass since the only commit on this branch is clean)