release: @eddacraft/[email protected] — cargo package pin + option allowlist#6
Merged
Conversation
Nx writes analytics: true into the fixture during e2e runs. Commit the current state so subsequent runs see a clean working tree.
Two consumer-surfaced defects that broke pre-publish validation:
- inferProjectConfig now seeds every cargo-backed target with
{ package: pkg.name }. Without it, the cargo executor fell back to
context.projectName, and when @nx/js claimed the project name from a
sibling package.json (napi-rs bindings) cargo received -p @scope/name
and rejected the invocation.
- buildCargoArgs takes a per-subcommand allowedKeys set unioned with
the base cargo keys. Anything outside that union is dropped before
argv is built, so Nx-merged CLI args (e.g. vitest --run/--coverage
from `nx run-many -t test`) no longer leak into `cargo test`.
Each cargo-wrapping executor declares its own allowlist; fmt and
release-publish use a hand-rolled argv builder and were unaffected.
0.1.0 is already on npm; the cargo-package and option-leak fixes ship as a patch release. CHANGELOG promotes the Unreleased block to 0.1.1; APS module records R4 complete and R4.1 in progress.
joshuaboys
changed the title
Previously hard-coded `eddacraft-nxrust-0.1.0.tgz`, so the 0.1.1 bump broke the e2e smoke job (`pnpm pack` produced 0.1.1.tgz, the install step still asked for 0.1.0.tgz). Derive the name from the package's own metadata so version bumps don't need a parallel edit here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release. 0.1.0 is already published to npm and can't be overwritten, so these consumer-surfaced fixes ship as 0.1.1.
Summary
{ package: pkg.name }. Fixescargo -p @scope/namefailures when@nx/jsclaims the project name from a siblingpackage.json(napi-rs bindings).--run,--coveragefromnx run-many -t testin mixed JS+Rust workspaces) leaking intocargo test.package.jsonto0.1.1and add a CHANGELOG entry.prepublishOnlygates, e2e smoke workflow).Test plan
pnpm test— 47/47 green (incl. new specs covering both fixes)pnpm typecheck— cleanpnpm build— cleanmain:pnpm publishand verifynpm view @eddacraft/[email protected]resolves@eddacraft/nxrust@^0.1.1