Skip to content

Conversation

@edgarWolf
Copy link
Owner

No description provided.

@edgarWolf edgarWolf requested a review from windisch June 5, 2025 12:35
Copy link
Collaborator

@windisch windisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

name (str): The name of the dataset specification.
spec (dict): The yaml-specification of the dataset.
f (Callable): The function to fit the curves.
w0 (list[float]): The inital guess.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
w0 (list[float]): The inital guess.
w0 (np.ndarray): The inital value.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

Suggested change
w0 (list[float]): The inital guess.
w0 (np.ndarray): The inital value for the internal paramters.

?

@edgarWolf edgarWolf requested a review from windisch June 6, 2025 09:42
@edgarWolf
Copy link
Owner Author

@windisch Have added/fixed some older docstrings and made sure everything gets now rendered properly.

@edgarWolf edgarWolf merged commit 34fb68f into main Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants