Skip to content
This repository was archived by the owner on Feb 5, 2021. It is now read-only.

Rails3 fix dimension ratings #95

Open
sfsekaran wants to merge 2 commits into
base: rails3
Choose a base branch
from
Open

Rails3 fix dimension ratings #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379175f
Fixing Rails compatibility (3.2.13 bug, but is forwards compatible)
sfsekaran Jun 16, 2013
e6498ef
Found a bug: dimension max stars check was incorrect.
sfsekaran Jun 16, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/axr/model.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,15 @@ def axr_config(dimension = nil)
# # some page update here ...
# end
def rate(stars, user, dimension = nil)
return false if (stars.to_i > self.class.max_stars) || (stars.to_i < 1)
return false if (stars.to_i > self.class.max_stars(dimension)) || (stars.to_i < 1)
raise Errors::AlreadyRatedError if (!self.class.axr_config(dimension)[:allow_update] && rated_by?(user, dimension))

rate = if self.class.axr_config(dimension)[:allow_update] && rated_by?(user, dimension)
rate_by(user, dimension)
else
rates(dimension).build.tap do |r|
r.rater = user
r.dimension = dimension
end
end
rate.stars = stars
Expand Down Expand Up @@ -128,7 +129,10 @@ def raters(dimension = nil)

# Finds the rate made by the user if he/she has already voted.
def rate_by(user, dimension = nil)
rates(dimension).find_by_rater_id(user.id)
rates(dimension).
where(:dimension => dimension).
where(:rater_id => user.id).
first
end

# Return true if the user has rated the object, otherwise false
Expand Down