Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edgedb-js/create refactor #1186

Merged
merged 2 commits into from
Jan 27, 2025
Merged

edgedb-js/create refactor #1186

merged 2 commits into from
Jan 27, 2025

Conversation

diksipav
Copy link
Contributor

@diksipav diksipav commented Jan 27, 2025 •
edited
Loading

Use PackageManager class.
Use user's package runner to run the Gel CLI instead of installing it.

@diksipav diksipav requested a review from scotttrinh January 27, 2025 19:24
@diksipav diksipav mentioned this pull request Jan 27, 2025
Closed
@diksipav diksipav changed the title Create pkg update edgedb-js/create refactor Jan 27, 2025
scotttrinh
scotttrinh approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@diksipav diksipav merged commit 138ce6a into gel Jan 27, 2025
8 of 9 checks passed
@diksipav diksipav deleted the create-pkg-update branch January 27, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotttrinh scotttrinh scotttrinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diksipav @scotttrinh