Tool for generating schema type annotations #7186
Open
+12,178
−190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our schema classes have generated getter methods for each of the fields:
This PR adds a tool that generates
.pyi
files inedb/schema/
, which contain definitions for all of these generated getters.We do have mypy extension that already picks-up these getters, even without
.pyi
definitions.Regardless, this
.pyi
approach is useful because language servers (PyLance) cannot use mypy extension. Now, "go to definition", "show usages" and other code actions work.There is a few drawbacks:
get_subjectexpr
returnsExpression
, but it will infer type ofsubjexpr
to beAny
. What?Because of these drawbacks, #7166 is still useful.