Bring old readability-server into this repo #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to actually get automation running here, this needs to incorporate the readability server we use. I've updated the code *slightly* to account for stuff that's now built-in for more modern versions of Node.js and to use NPM instead of Yarn. It also uses the `@mozilla/readability` NPM package, which seems to be more reliably and actively updated these days (we used to install straight from git because the repo was years more up to date than the package). Doing this has reminded me of all the things that don't work well in Mozilla's Readability. Really makes me want to take another look at Postlight or at our own stuff, which only ever got halfway done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though there are long-standing issues with Readability (see #9), we never really completed and validated a viable alternative of our own. We really need to get this tool automated, so for now that means we need to pull in Readability so this repo contains everything needed to actually run the analysis scripts.
This imports the old readability-server from the web-monitoring-changed-terms-analysis repo. I also made a few minor updates as part of doing so:
@mozilla/readabilityNPM package. We used to use their git repo directly because the NPM module seemed unmaintained (the repo had years-newer updates!). This no longer seems to be an issue.