Skip to content

refactor(storybook): #ENABLING-684 update storybook to v9#440

Merged
pascalsaussier-edifice merged 9 commits intodevelop-enablingfrom
refactor-update-storybook
Mar 26, 2026
Merged

refactor(storybook): #ENABLING-684 update storybook to v9#440
pascalsaussier-edifice merged 9 commits intodevelop-enablingfrom
refactor-update-storybook

Conversation

@pascalsaussier-edifice
Copy link
Collaborator

@pascalsaussier-edifice pascalsaussier-edifice commented Jan 9, 2026

Description

  • Updates Storybook from v8 to v9.
  • Updates "@chromatic-com/storybook": "^4.1.3",
  • Updates "eslint-plugin-storybook": "9.1.17",
  • Deletes @pixi/react from packages/react,
  • Updates pixi.js from packages/react to 8.15.0,
  • Updates ImageEditor component to use latest pixi version
  • Add a story for ImageEditor to test modifications
  • Lint Css for packages/bootstrap/src/components/_media-library.scss file (replacement of rgba function)

Which Package changed?

Please check the name of the package you changed

  • Components
  • Core
  • Icons
  • Hooks

Has the documentation changed?

  • Storybook

Type of change

Please check options that are relevant.

  • Chore (PATCH)
  • Doc (PATCH)
  • Bug fix (PATCH)
  • New feature (MINOR)
  • Breaking change (MAJOR)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Storybook from v8 to v9, updates related dependencies, and makes necessary code changes to support the new version. The upgrade includes updating import paths from @storybook/blocks to @storybook/addon-docs/blocks, changing @storybook/react imports to @storybook/react-vite, and updating the PixiJS library and its React bindings in the ImageEditor component.

Changes:

  • Storybook upgraded from v8.4.5 to v9.1.17 across all related packages
  • Import paths updated for Storybook v9 compatibility throughout story files and MDX documentation
  • PixiJS and @pixi/react updated to v8.x with corresponding API changes in ImageEditor component

Reviewed changes

Copilot reviewed 164 out of 165 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates Storybook core and addon packages to v9.1.17
packages/react/package.json Updates @pixi/react to 8.0.5 and pixi.js to 8.15.0
apps/docs/.storybook/main.ts Simplifies addon configuration and updates path resolution for v9
apps/docs/.storybook/manager.ts Changes import from @storybook/manager-api to storybook/manager-api
apps/docs/.storybook/theme.ts Updates theming import path for v9
apps/docs/.storybook/preview.tsx Changes import from @storybook/react to @storybook/react-vite
packages/react/src/modules/multimedia/ImageEditor/components/ImageEditor.tsx Updates PixiJS component from Stage to Application with new API
packages/react/src/hooks/useBrowserInfo/useBrowserInfo.ts Changes UAParser import to named export
packages/react/src/modules/modals/ResourceModal/ResourceModal.tsx Adds fallback to document.body for portal element
All .stories.tsx files Updates imports from @storybook/react to @storybook/react-vite
All .mdx files Updates imports from @storybook/blocks to @storybook/addon-docs/blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@david-cc david-cc self-requested a review January 9, 2026 17:23
Copy link
Member

@david-cc david-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faudra remonter à la team QA de tester le composant ImageEditor pour s’assurer que y’a pas de régression suite à cette montée de version, sinon OK pour moi !

@pascalsaussier-edifice pascalsaussier-edifice changed the title [Draft]refactor(storybook) update storybook to v9 refactor(storybook): #ENABLING-684 update storybook to v9 Mar 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 210 out of 210 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

packages/react/src/components/Grid/Grid.tsx:83

  • const Component = (as || 'div') as React.FC<...> is an incorrect type assertion for the polymorphic as prop: 'div' is not a function component, and as may be other ElementTypes. This can mask typing issues and make the as prop harder to use safely. Prefer keeping Component typed as React.ElementType (or using a generic polymorphic component type) rather than asserting React.FC.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pascalsaussier-edifice pascalsaussier-edifice changed the base branch from develop to develop-enabling March 23, 2026 10:39
@pascalsaussier-edifice pascalsaussier-edifice force-pushed the refactor-update-storybook branch 3 times, most recently from 2f77eff to 241754d Compare March 23, 2026 15:57
@pascalsaussier-edifice pascalsaussier-edifice merged commit 1a89b98 into develop-enabling Mar 26, 2026
2 of 4 checks passed
@pascalsaussier-edifice pascalsaussier-edifice deleted the refactor-update-storybook branch March 26, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants