refactor(storybook): #ENABLING-684 update storybook to v9#440
refactor(storybook): #ENABLING-684 update storybook to v9#440pascalsaussier-edifice merged 9 commits intodevelop-enablingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades Storybook from v8 to v9, updates related dependencies, and makes necessary code changes to support the new version. The upgrade includes updating import paths from @storybook/blocks to @storybook/addon-docs/blocks, changing @storybook/react imports to @storybook/react-vite, and updating the PixiJS library and its React bindings in the ImageEditor component.
Changes:
- Storybook upgraded from v8.4.5 to v9.1.17 across all related packages
- Import paths updated for Storybook v9 compatibility throughout story files and MDX documentation
- PixiJS and @pixi/react updated to v8.x with corresponding API changes in ImageEditor component
Reviewed changes
Copilot reviewed 164 out of 165 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Storybook core and addon packages to v9.1.17 |
| packages/react/package.json | Updates @pixi/react to 8.0.5 and pixi.js to 8.15.0 |
| apps/docs/.storybook/main.ts | Simplifies addon configuration and updates path resolution for v9 |
| apps/docs/.storybook/manager.ts | Changes import from @storybook/manager-api to storybook/manager-api |
| apps/docs/.storybook/theme.ts | Updates theming import path for v9 |
| apps/docs/.storybook/preview.tsx | Changes import from @storybook/react to @storybook/react-vite |
| packages/react/src/modules/multimedia/ImageEditor/components/ImageEditor.tsx | Updates PixiJS component from Stage to Application with new API |
| packages/react/src/hooks/useBrowserInfo/useBrowserInfo.ts | Changes UAParser import to named export |
| packages/react/src/modules/modals/ResourceModal/ResourceModal.tsx | Adds fallback to document.body for portal element |
| All .stories.tsx files | Updates imports from @storybook/react to @storybook/react-vite |
| All .mdx files | Updates imports from @storybook/blocks to @storybook/addon-docs/blocks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
david-cc
left a comment
There was a problem hiding this comment.
Faudra remonter à la team QA de tester le composant ImageEditor pour s’assurer que y’a pas de régression suite à cette montée de version, sinon OK pour moi !
6d036f1 to
c40319e
Compare
b2c3329 to
ab43d2f
Compare
67c1332 to
e81086b
Compare
e81086b to
de597af
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 210 out of 210 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
packages/react/src/components/Grid/Grid.tsx:83
const Component = (as || 'div') as React.FC<...>is an incorrect type assertion for the polymorphicasprop:'div'is not a function component, andasmay be otherElementTypes. This can mask typing issues and make theasprop harder to use safely. Prefer keepingComponenttyped asReact.ElementType(or using a generic polymorphic component type) rather than assertingReact.FC.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react/src/modules/multimedia/ImageEditor/components/ImageEditor.tsx
Outdated
Show resolved
Hide resolved
2f77eff to
241754d
Compare
241754d to
e55cee5
Compare
1a89b98
into
develop-enabling
Description
@pixi/reactfrompackages/react,pixi.jsfrompackages/reactto 8.15.0,ImageEditorcomponent to use latest pixi versionpackages/bootstrap/src/components/_media-library.scssfile (replacement of rgba function)Which Package changed?
Please check the name of the package you changed
Has the documentation changed?
Type of change
Please check options that are relevant.
Checklist: