feat(add-theme): #ENABLING-653 add new theme neov2#465
Draft
pascalsaussier-edifice wants to merge 1 commit intodevelop-enablingfrom
Draft
feat(add-theme): #ENABLING-653 add new theme neov2#465pascalsaussier-edifice wants to merge 1 commit intodevelop-enablingfrom
pascalsaussier-edifice wants to merge 1 commit intodevelop-enablingfrom
Conversation
2a69bdf to
81723bb
Compare
6619a1b to
ee26a09
Compare
81723bb to
fe093b3
Compare
ee26a09 to
db9db69
Compare
fe093b3 to
e30a575
Compare
db9db69 to
dce76bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the new
neov2theme, built upon a modernized theming architecture in thebootstrappackage. This new architecture leverages Sass maps and CSS variables to provide a more flexible and maintainable approach to theme development.Key changes include:
_theme-api.scssmodule defining a contract for themes based on configuration maps.neov2theme configuration, including its initial color palette and typography, is defined inconfigs/_neov2.scss._icons.scssabstract to theme-specific files (themes/neo/_icons.scss,themes/one/_icons.scss,themes/neov2/_icons.scss). The icon token generation (tokens/_icons.scss) now dynamically uses these theme-specific maps.neov2theme structure supports component-level overrides, as demonstrated by the newoverrides/directory.neov2to guide future theme development and migration efforts.neov2theme is integrated into Storybook, allowing for easy preview and testing.packages/react/src/hooks/useBrowserInfo/useBrowserInfo.tschanges the import style forUAParser.This initiative, related to #ENABLING-653, lays the groundwork for a progressive migration to a more robust and scalable theming system.
Which Package changed?
Has the documentation changed?
Type of change
Please check options that are relevant.
Checklist: