Squashed commit of the following:

commit 7ca889731772dca92d83474b242c889f835aefb2 Author: eduran84 <[email protected]> Date: Sun Apr 28 19:14:03 2019 +0200 Fixed bug in player_init code that caused error when hiding toggle button. commit 945e877fa65e5e867772809c173ed297a56890e3 Author: eduran84 <[email protected]> Date: Sun Apr 28 19:10:57 2019 +0200 Bugfix: Changelog, version to 0.10.8 commit b88d83ba97fe5f2b16a58e5384fe5a1c4885e50c Author: eduran84 <[email protected]> Date: Sun Apr 28 19:06:40 2019 +0200 Fixed #25: show-button setting not respected in player_init commit 77781d34fb778faf11f654148a06e6069e1e638f Author: eduran84 <[email protected]> Date: Sun Apr 28 19:02:57 2019 +0200 removed periods from setting locale strings
eduran84 · Apr 28, 2019 · a457bed · a457bed
1 parent 5b083e2
commit a457bed
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -1,3 +1,11 @@
+---------------------------------------------------------------------------------------------------
+Version: 0.10.8
+Date: 2019-04-28
+
+  Bugfixes:
+    - Fixed that "Show toggle button" setting was not respected at the start of the game. (#25)
+    - Fixed that "Show toggle button" setting could sometimes revert to "on" when loading a game. (#25)
+
 ---------------------------------------------------------------------------------------------------
 Version: 0.10.7
 Date: 2019-04-25

diff --git a/control.lua b/control.lua
@@ -36,7 +36,6 @@ custom_events = {
 log2 = require("__OpteraLib__.script.logger").log
 ui = require("script.gui_ctrl")
 local prc = require("script.data_processing")
-local ui = ui
 
 script.on_init(function()
   -- check for LTN

diff --git a/info.json b/info.json
@@ -1,6 +1,6 @@
 {
 "name": "LTN_Tracker",
-"version": "0.10.7",
+"version": "0.10.8",
 "title": "LTN Tracker",
 "author": "eduran",
 "contact": "https://forums.factorio.com/memberlist.php?mode=viewprofile&u=1699",

diff --git a/locale/en/ltnt_en.cfg b/locale/en/ltnt_en.cfg
@@ -120,8 +120,8 @@ delete-all-tt=Clear entire error list.
 select-tt=Open train UI.
 
 [mod-setting-name]
-ltnt-show-button=Show toggle button.
-ltnt-window-height=Window height (pixel).
+ltnt-show-button=Show toggle button
+ltnt-window-height=Window height (pixel)
 ltnt-refresh-interval=Auto-refresh interval (seconds)
 ltnt-debug-level=Enable debug logging
 ltnt-history-limit=History limit

diff --git a/script/gui_ctrl.lua b/script/gui_ctrl.lua
@@ -72,8 +72,8 @@ local function player_init(pind)
 
   -- build UI
   GC.toggle_button:build(button_flow, pind)
-  if not settings.get_player_settings(player)["ltnt-show-button"] then
-    GC.toggle_button:hide(player)
+  if not settings.get_player_settings(player)["ltnt-show-button"].value then
+    GC.toggle_button:hide(pind)
   end
   GC.outer_frame:build(frame_flow, pind)
   GC.outer_frame:hide(pind) -- UI is always closed on init