Add support for private npm installs into edxapp. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelroytman
commented
Mar 18, 2025
| @@ -317,6 +317,16 @@ | |||
| - install | |||
| - install:app-requirements | |||
|
|
|||
| - name: Install private node dependencies | |||
| shell: "easy_install --version && npm clean-install" | |||
There was a problem hiding this comment.
I know this isn't the right command. I'm not sure how to
- how to separate the installation of public and private npm modules, because the current command to install npm modules is npm clean-install.
- how a package-lock.json is generated, since npm clean-install will need to compare against it
michaelroytman
force-pushed
the
michaelroytman/COSMO-683-private-npm-installs-edxapp
branch
from
25542ba to
38da6c5
Compare
michaelroytman
force-pushed
the
michaelroytman/COSMO-683-private-npm-installs-edxapp
branch
from
38da6c5 to
f9609bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the following steps are done before merging: