Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from perfect, considering that I basically know nothing about ReShade, Basalt, or anything related to those.
As such, this "pull request" is more of an attempt at helping refactoring the python code itself, than the logic behind it.
I don't have many files to test with, and I don't know what an expected result is precisely, so this will need a lot of testing that I'm not qualified to make.
Changes include a lot of simplifications (maybe a bit too much actually, since I completely destroyed the object-oriented structure, but I didn't see any advantage with it), and the use of GitPython and Click to respectively have a more robust git handling and CLI.
I can't be sure that the behaviour is the same as intended, since the original code didn't work for me. I tried to keep the logic intact from what I understood of the code itself, but that's basically it.
Also, this is more of a draft than anything. I didn't really spend time polishing it, since I don't know if it's worth anything (or even working at all).