Deliver holes for literate Effekt files #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
reviewed
Jun 4, 2025
Comment on lines
38
to
43
| override def compileSource(source: Source, config: EffektConfig): Unit = try { | ||
| val src = if (source.name.endsWith(".md")) { MarkdownSource(source) } else { source } | ||
| override def compileSource(source: Source, config: EffektConfig): Unit = { | ||
| val src = if (source.name.endsWith(".md")) { | ||
| MarkdownSource(source) | ||
| } else { | ||
| source | ||
| } |
There was a problem hiding this comment.
This confused me at first since I couldn't tell what changed -- only the try got moved, right?
There was a problem hiding this comment.
It is hard to see indeed; indenting the code triggered a reformat by intelliJ. If you want I can try to use another tool to reproduce the change with smaller diff.
What changed is: src is being initialized before the try block, the statements in finally use src rather than source.
timsueberkrueb
force-pushed
the
deliver-holes-for-literate-files
branch
from
0156f9d to
6398ca6
Compare
jiribenes
approved these changes
Jun 15, 2025
There was a problem hiding this comment.
I think this is OK, but it's pretty hard to see if the try-catch-finally logic is 100% sound.
Feel free to merge if you're happy with this, @timsueberkrueb
b-studios
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only published holes for
.effektbut not foreffekt.md. The reason for this is that for*.mdfiles we construct a newMarkdownSourceincompileSourceand we attach the annotations to that, but we pass the oldStringSourceback toafterCompilation, meaning we don't find the annotations.This PR fixes this issue by passing the correct source to
afterCompilation.