Skip to content

Update postgres version, infra creation failing error throwing is enabled and enabled monitoring #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update postgres version, infra creation failing error throwing is enabled and enabled monitoring #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea126e
Change continue-on-error to false to throw error if infra creation fails
vinothrallapalli-eGov Nov 25, 2025
3b86545
enable monitoring by default
vinothrallapalli-eGov Nov 25, 2025
7eeab35
Update default PostgreSQL version to 15.12
vinothrallapalli-eGov Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/digit_install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
- name: Terraform Apply - remotestate
id: apply
run: terraform apply -no-color -input=false -auto-approve
continue-on-error: true
continue-on-error: false
working-directory: devops/infra-as-code/terraform/sample-aws/remote-state
Comment on lines 155 to 159
Copy link

@coderabbitai coderabbitai bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Inconsistent error handling between remotestate and main infra apply steps.

Line 158 sets continue-on-error: false to fail on remotestate Terraform errors, but line 179 sets continue-on-error: true for main infra apply. This asymmetry could mask real infrastructure failures during main apply, allowing the workflow to proceed with incomplete infrastructure and potentially fail silently in downstream steps.

Clarify the intent: Should both steps use the same error handling strategy? If main infra apply errors are acceptable to ignore, add explicit checks in subsequent steps to verify infrastructure readiness before proceeding to deployment.

Consider aligning error handling:

  - name: Terraform Apply - Infra creation
    id: apply-Infra
    run: terraform apply -no-color -input=false -auto-approve -var db_password=$db_password
-   continue-on-error: true
+   continue-on-error: false
    working-directory: devops/infra-as-code/terraform/sample-aws

Or, if continuing on error is intentional, add a verification step:

  - name: Verify Terraform Apply succeeded
    run: |
      if [ "${{ steps.apply-Infra.outcome }}" != "success" ]; then
        echo "WARNING: Infra apply failed but continuing. Verify infrastructure state."
      fi
🤖 Prompt for AI Agents 
.github/workflows/digit_install.yml lines 155-159: the Terraform remotestate
apply step uses continue-on-error: false while the main infra apply later uses
continue-on-error: true, creating inconsistent error handling that can mask real
failures; either make both steps use the same policy (set continue-on-error:
false for main infra apply to fail fast) or, if continuing on main apply is
intentional, add an explicit verification step immediately after the main infra
apply that checks the apply step outcome (using the main apply step id/outcome
or exit code) and fails or alerts if it did not succeed so downstream steps only
run when infra is verified.

- name: Terraform init - Infra creation
id: init-Infra
Expand Down
3 changes: 1 addition & 2 deletions devops/deploy-as-code/digit-helmfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@ helmfiles:
- path: ./charts/urban/urban-helmfile.yaml
- path: ./charts/common-services/common-services-helmfile.yaml
- path: ./charts/analytics/analytics-helmfile.yaml
# - path: ./charts/sanitation/sanitation-helmfile.yaml
- path: ./charts/auxiliary-services/auxiliary-helmfile.yaml
# - path: ./charts/monitoring/monitoring-helmfile.yaml
- path: ./charts/monitoring/monitoring-helmfile.yaml
2 changes: 1 addition & 1 deletion devops/infra-as-code/terraform/sample-aws/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ variable "max_worker_nodes" {

variable "db_version" {
description = "postgres version"
default = "15.8"
default = "15.12"
}

variable "db_instance_type" {
Expand Down