Skip to content

Hcmpre 3049 #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 85 commits into from
+7,096 −1,092
Closed

Hcmpre 3049 #3183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
4bbf716
edit compoent is designed
pitabash-eGov Aug 18, 2025
c65b2ee
deenroll API service added. need to be called in the pop up screen
pitabash-eGov Aug 18, 2025
57383fa
changes are there for warning pop for disabling user
pitabash-eGov Aug 20, 2025
0eefbb1
disable user functionality working now
pitabash-eGov Aug 20, 2025
ab6da34
table constant added for pagination view
pitabash-eGov Aug 20, 2025
dc896d1
localisation and bredcum issue resolved
pitabash-eGov Aug 21, 2025
a029f71
user search pop up screen mentioned
pitabash-eGov Aug 22, 2025
97900d5
enroll attendee service and search individual written
pitabash-eGov Aug 22, 2025
8c8e9ca
url added in the set up proxy
pitabash-eGov Aug 22, 2025
0d4ff6a
search individual in progress
pitabash-eGov Aug 25, 2025
6c42a32
search attendee inbox and digit-ui-component upgraded
pitabash-eGov Aug 26, 2025
f123474
enrolling attendeefron inbox screen
pitabash-eGov Sep 9, 2025
4884c43
user assignment is in progress
pitabash-eGov Sep 10, 2025
be4bc7d
attendee inbox pagination started working
pitabash-eGov Sep 10, 2025
1246f82
made changes in the localisation
pitabash-eGov Sep 10, 2025
0f597bb
reporting to issue fixed. but needs to be reviewd
pitabash-eGov Sep 10, 2025
2697ffb
hrms attendee create config added
pitabash-eGov Sep 11, 2025
e7f2100
localization added
pitabash-eGov Sep 11, 2025
7c06320
hrms module added in the payments-ui context path
pitabash-eGov Sep 11, 2025
37dd6ec
space removed
pitabash-eGov Sep 11, 2025
afdfb77
health-hrms module added for build
pitabash-eGov Sep 11, 2025
c401a98
start build added
pitabash-eGov Sep 11, 2025
efaaba0
hrms module added in the payment workspace
pitabash-eGov Sep 11, 2025
267d49e
HRMS module console added to check it is loading or not and some othe…
pitabash-eGov Sep 15, 2025
81e9337
HRMS card added
pitabash-eGov Sep 15, 2025
418aa25
UI issue and hint text fixed
pitabash-eGov Sep 15, 2025
050c8aa
ActionBar component not supported in the digit-ui-component. so used …
pitabash-eGov Sep 16, 2025
9aef441
loader ui put in center
pitabash-eGov Sep 17, 2025
cceb7ac
hierarchyType is referred from global config
pitabash-eGov Sep 17, 2025
9d6d3c4
old loader component is removed
pitabash-eGov Sep 17, 2025
199a9e5
in the response screen the proceed for campaign assignment button adj…
pitabash-eGov Sep 22, 2025
d70bc7b
hard coded tenant ID replaced
pitabash-eGov Sep 23, 2025
3e27877
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Sep 29, 2025
3f9126a
UI issues fixed
pitabash-eGov Sep 30, 2025
dc54d7f
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Sep 30, 2025
43236d9
dss commented
pitabash-eGov Sep 30, 2025
ce1e7a5
Patch of Navigation and Dependent Fields Changes
Ramkrishna-egov Sep 30, 2025
1359ccd
loader handled in center
pitabash-eGov Sep 30, 2025
85641f3
Fixes for adding navigation condition
Ramkrishna-egov Sep 30, 2025
843271a
Enabled Local LocalisationWrapper
Ramkrishna-egov Sep 30, 2025
fad6773
Added missing parentState from local components
Ramkrishna-egov Oct 1, 2025
5e0a345
Fixed Complaints module components
Ramkrishna-egov Oct 1, 2025
ddfe94c
Fixed page ordering issues for sub form flow
Ramkrishna-egov Oct 1, 2025
5a02468
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Oct 3, 2025
f062f8e
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Oct 3, 2025
a49d420
UI issue fixed
pitabash-eGov Oct 3, 2025
a62ae24
error toast message added on campaign start dat enot selected
pitabash-eGov Oct 3, 2025
a38e386
loader added while create API call and loader put in middle
pitabash-eGov Oct 3, 2025
a00835f
loader put in center
pitabash-eGov Oct 3, 2025
a42e623
Merge branch 'HCMPRE_3099' of https://github.com/egovernments/DIGIT-F…
pitabash-eGov Oct 3, 2025
2cc6721
village dropdown was not getting reset issue fixed at boundary level …
pitabash-eGov Oct 3, 2025
45aa7cd
mdmsv2: true commented in the createemployee config in the hrms
pitabash-eGov Oct 6, 2025
856733b
Validations array fixes
Ramkrishna-egov Oct 7, 2025
d8c1b7e
reporting to user section converted to pagination
pitabash-eGov Oct 8, 2025
361439d
search button added on the right side
pitabash-eGov Oct 9, 2025
c1cc1da
Merge branch 'uat-navigation-depnedency' of https://github.com/egover…
pitabash-eGov Oct 9, 2025
3aa4602
space issue fixed for back button
pitabash-eGov Oct 9, 2025
df1eb2f
removed bold style from project selection label
pitabash-eGov Oct 10, 2025
43d69ef
edit attendee pop screen is made responsive
pitabash-eGov Oct 10, 2025
9d30480
village level dropdown options made little visible
pitabash-eGov Oct 10, 2025
f7b7ee0
Fixes for Next button when only 1 page there in the flow
Ramkrishna-egov Oct 10, 2025
ee4a13d
Merge branch 'uat-navigation-depnedency' of https://github.com/egover…
pitabash-eGov Oct 10, 2025
65aceea
register inbox table UI scrolling issue fixes
pitabash-eGov Oct 13, 2025
f5a2b4c
BUGFIX:: parentState not defined
Ramkrishna-egov Oct 13, 2025
d0d85a5
BUGFIX:: Selected Field not defined error fixes
Ramkrishna-egov Oct 13, 2025
4def1d7
Merge branch 'HCMPRE_3099' of https://github.com/egovernments/DIGIT-F…
pitabash-eGov Oct 13, 2025
dcbdcaf
hirachy selection label bold removed
pitabash-eGov Oct 13, 2025
4bdb200
Dependent Field Fixes
Ramkrishna-egov Oct 13, 2025
67edb4d
my bills issue fixed
pitabash-eGov Oct 14, 2025
435f47f
table register pop up scroll issue fixed
pitabash-eGov Oct 14, 2025
44f8d8a
no data found
pitabash-eGov Oct 14, 2025
f17b433
hrms hierachy selection ui issue fixed
pitabash-eGov Oct 14, 2025
506d9bc
UI issue for edit attendee table issue fixed
pitabash-eGov Oct 15, 2025
84c87bd
project selection label font issue fixed
pitabash-eGov Oct 15, 2025
08db216
bill inbox infoCard issue fixed
pitabash-eGov Oct 15, 2025
407d1d5
Merge branch 'uat-navigation-depnedency' of https://github.com/egover…
pitabash-eGov Oct 15, 2025
42d5a65
redirection issue for view attendance and edit register fixed
pitabash-eGov Oct 16, 2025
165d1ef
digit-ui-components": from "0.2.0-beta.58" to "0.2.0-beta.58"
pitabash-eGov Oct 17, 2025
80a1fd9
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Oct 17, 2025
cc3c42d
Merge branch 'master' of https://github.com/egovernments/DIGIT-Fronte…
pitabash-eGov Oct 21, 2025
2e3a081
session time frame handled for enrolment and disable attendee
pitabash-eGov Oct 22, 2025
349273f
debugger removed
pitabash-eGov Oct 22, 2025
ad2872c
added code comment
pitabash-eGov Oct 23, 2025
70e0beb
trying to adjust to pick up the local timezone
pitabash-eGov Oct 23, 2025
5acd6d8
unused files removed
pitabash-eGov Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion health/micro-ui/web/health-payments/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { DigitUI } from "@egovernments/digit-ui-module-core";

import { UICustomizations } from "./Customisations/UICustomizations";
import { initPaymentComponents } from "@egovernments/digit-ui-module-health-payments";
import { initHRMSComponents } from "@egovernments/digit-ui-module-health-hrms";
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Lazy‑load and feature‑gate HRMS to prevent bundle bloat and startup breakage

Static importing HRMS makes it mandatory at build time and increases initial bundle. Prefer dynamic import behind a config flag.

Apply this diff to drop the static import:

-import { initHRMSComponents } from "@egovernments/digit-ui-module-health-hrms";

Then, initialize HRMS dynamically inside initDigitUI:

// inside initDigitUI(), after initPaymentComponents()
const enableHRMS = window.globalConfigs?.getConfig("ENABLE_HRMS") === "true";
if (enableHRMS) {
  import("@egovernments/digit-ui-module-health-hrms")
    .then(({ initHRMSComponents }) => initHRMSComponents?.())
    .catch((err) => console.error("Failed to initialize HRMS module:", err));
}

Verification script to ensure dependency and registrations exist:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Check dependency presence:"
fd -a package.json | xargs -I{} sh -c 'echo "== {} =="; jq -r \'.dependencies["@egovernments/digit-ui-module-health-hrms"] // .devDependencies["@egovernments/digit-ui-module-health-hrms"] // "MISSING"\' {}'

echo -e "\nFind HRMS init/registry markers:"
rg -nP -C2 --hidden --glob '!**/node_modules/**' '(initHRMSComponents|moduleName\s*:\s*"HRMS"|Digit\.ComponentRegistryService)'

echo -e "\nFind Payments init/registry markers:"
rg -nP -C2 --hidden --glob '!**/node_modules/**' '(initPaymentComponents|moduleName\s*:\s*"Payments")'

Length of output: 88

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Checking for package.json files and HRMS dependency ==="
mapfile -t PKG_FILES < <(fd -a package.json || true)
if [ ${#PKG_FILES[@]} -eq 0 ]; then
  echo "No package.json files found"
else
  for f in "${PKG_FILES[@]}"; do
    echo "== $f =="
    jq -r '((.dependencies // {}) + (.devDependencies // {})) | .["@egovernments/digit-ui-module-health-hrms"] // "MISSING"' "$f" || echo "jq failed on $f"
  done
fi

echo
echo "=== Searching repo for HRMS import / usage ==="
rg -n --hidden --glob '!**/node_modules/**' '@egovernments/digit-ui-module-health-hrms' || echo "No direct imports of the package found"

echo
echo "=== Searching for initHRMSComponents, initPaymentComponents, initDigitUI ==="
rg -nP -C2 --hidden --glob '!**/node_modules/**' 'initHRMSComponents' || true
rg -nP -C2 --hidden --glob '!**/node_modules/**' 'initPaymentComponents' || true
rg -nP -C3 --hidden --glob '!**/node_modules/**' 'function\s+initDigitUI\b|const\s+initDigitUI\s*=' || true

echo
echo "=== Show top of health/micro-ui/web/health-payments/App.js (if present) ==="
TARGET="health/micro-ui/web/health-payments/App.js"
if [ -f "$TARGET" ]; then
  echo "== $TARGET =="
  sed -n '1,160p' "$TARGET"
else
  echo "File not found: $TARGET"
  rg -n --hidden --glob '!**/node_modules/**' 'health-payments/App.js' || true
fi

Length of output: 116

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Environment ==="
echo "PWD: $(pwd)"
echo "BASH_VERSION: $BASH_VERSION"
if command -v rg >/dev/null 2>&1; then rg --version | head -n1; else echo "rg: not found"; fi
if command -v fd >/dev/null 2>&1; then fd --version | head -n1; else echo "fd: not found"; fi
if command -v jq >/dev/null 2>&1; then jq --version; else echo "jq: not found"; fi
echo

echo "=== Checking package.json files for HRMS dependency ==="
PKG_COUNT=$(find . -type f -name package.json 2>/dev/null | wc -l || true)
if [ "${PKG_COUNT:-0}" -eq 0 ]; then
  echo "No package.json files found"
else
  find . -type f -name package.json -print0 2>/dev/null | while IFS= read -r -d '' f; do
    echo "== $f =="
    if command -v jq >/dev/null 2>&1; then
      jq -r '((.dependencies // {}) + (.devDependencies // {})) | .["@egovernments/digit-ui-module-health-hrms"] // "MISSING"' "$f" || echo "jq failed on $f"
    else
      echo "jq not available — showing top of package.json:"
      sed -n '1,200p' "$f" | head -n 40
    fi
  done
fi

echo
echo "=== Searching codebase for module/import/usages ==="
if command -v rg >/dev/null 2>&1; then
  rg -n --hidden --glob '!**/node_modules/**' '@egovernments/digit-ui-module-health-hrms' || echo "No direct imports of the package found"
  rg -n --hidden --glob '!**/node_modules/**' 'initHRMSComponents' || echo "No matches for initHRMSComponents"
  rg -n --hidden --glob '!**/node_modules/**' 'initPaymentComponents' || echo "No matches for initPaymentComponents"
  rg -n --hidden --glob '!**/node_modules/**' 'initDigitUI' || echo "No matches for initDigitUI"
else
  echo "rg not available — falling back to grep"
  grep -RIn --exclude-dir=node_modules '@egovernments/digit-ui-module-health-hrms' . || echo "No direct imports found (grep)"
  grep -RIn --exclude-dir=node_modules 'initHRMSComponents\|initPaymentComponents\|initDigitUI' . || true
fi

echo
echo "=== Inspecting health/micro-ui/web/health-payments/App.js ==="
TARGET="health/micro-ui/web/health-payments/App.js"
if [ -f "$TARGET" ]; then
  echo "== $TARGET =="
  sed -n '1,240p' "$TARGET"
else
  echo "File not found: $TARGET"
  if command -v rg >/dev/null 2>&1; then
    rg -n --hidden --glob '!**/node_modules/**' 'health-payments/App.js' || true
  fi
fi

Length of output: 2561

Lazy‑load and feature‑gate HRMS to prevent bundle bloat and startup breakage

health/micro-ui/web/health-payments/App.js statically imports and calls initHRMSComponents during startup — change to a dynamic import behind a config flag so HRMS isn't bundled/initialized unless enabled.

Apply this diff to drop the static import:

-import { initHRMSComponents } from "@egovernments/digit-ui-module-health-hrms";

Then, initialize HRMS dynamically inside initDigitUI() (after initPaymentComponents()):

const enableHRMS = window.globalConfigs?.getConfig("ENABLE_HRMS") === "true";
if (enableHRMS) {
  import("@egovernments/digit-ui-module-health-hrms")
    .then(({ initHRMSComponents }) => initHRMSComponents?.())
    .catch((err) => console.error("Failed to initialize HRMS module:", err));
}
🤖 Prompt for AI Agents 
In health/micro-ui/web/health-payments/App.js around line 8, the file currently
statically imports initHRMSComponents which causes HRMS to be bundled and
initialized at startup; remove that static import and instead lazy-load and
feature-gate HRMS inside initDigitUI() after initPaymentComponents().
Specifically, read the ENABLE_HRMS flag from
window.globalConfigs.getConfig("ENABLE_HRMS") === "true", and when true perform
a dynamic import of "@egovernments/digit-ui-module-health-hrms", then call
initHRMSComponents if present and log any import/initialization errors to
console.error. Ensure the static import is deleted so HRMS is not included in
the main bundle.



const enabledModules = [
Expand All @@ -13,7 +14,8 @@ const enabledModules = [
"Utilities",
"Engagement",
"Workbench",
"Payments"
"Payments",
"HRMS"
];
Comment on lines +17 to 19
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Gate “HRMS” in enabledModules via config and confirm registry key matches

Avoid exposing HRMS where not intended. Also ensure the module key matches what Module.js registers (typically "HRMS").

Apply this diff to conditionally include HRMS:

   "Workbench",
-  "Payments",
-  "HRMS"
-];
+  "Payments",
+].concat(window.globalConfigs?.getConfig("ENABLE_HRMS") === "true" ? ["HRMS"] : []);

Quick checks:

  • Verify health-hrms Module.js registers as "HRMS".
  • Confirm RBAC/MDMS config allows HRMS for the intended tenants/users.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Payments",
"HRMS"
];
"Workbench",
"Payments",
].concat(window.globalConfigs?.getConfig("ENABLE_HRMS") === "true" ? ["HRMS"] : []);


const moduleReducers = (initData) => ({
Expand All @@ -24,6 +26,7 @@ const initDigitUI = () => {
window.Digit.ComponentRegistryService.setupRegistry({
});
initPaymentComponents();
initHRMSComponents();
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Defensive init for HRMS (if you keep static import)

If you keep the static import, at least guard and catch init errors to avoid white‑screen on partial deployments.

-  initHRMSComponents();
+  if (window.globalConfigs?.getConfig("ENABLE_HRMS") === "true") {
+    try {
+      initHRMSComponents();
+    } catch (e) {
+      console.error("Failed to initialize HRMS module:", e);
+    }
+  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
initHRMSComponents();
if (window.globalConfigs?.getConfig("ENABLE_HRMS") === "true") {
try {
initHRMSComponents();
} catch (e) {
console.error("Failed to initialize HRMS module:", e);
}
}
🤖 Prompt for AI Agents 
In health/micro-ui/web/health-payments/App.js around line 29, the unguarded call
to initHRMSComponents() can throw during partial deployments and cause a white
screen; wrap the call in a safety guard by checking that initHRMSComponents is a
function before invoking it and execute it inside a try/catch block that logs
the error and prevents it from bubbling (optionally fall back to a no-op), so
initialization failures are caught and do not crash the app.


window.Digit.Customizations = {
PGR: {},
Expand Down
5 changes: 4 additions & 1 deletion health/micro-ui/web/health-payments/inter-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"version": "1.0.0",
"main": "index.js",
"workspaces": [
"packages/modules/health-payments"
"packages/modules/health-payments",
"packages/modules/health-hrms"
],
"author": "JaganKumar <[email protected]>",
"license": "MIT",
Expand All @@ -21,12 +22,14 @@
"dev:example": "cd example && yarn start",
"dev:hcm-microplanning": "cd packages/modules/hcm-microplanning && yarn start",
"dev:health-payments": "cd packages/modules/health-payments && yarn start",
"dev:health-hrms": "cd packages/modules/health-hrms && yarn start",
"dev:microplan": "cd packages/modules/microplan && yarn start",
"dev:campaign": "cd packages/modules/campaign-manager && yarn start",
"build": "run-p build:**",
"build:campaign": "cd packages/modules/campaign-manager && yarn build",
"buildD:hcm-microplanning": "cd packages/modules/hcm-microplanning && yarn build",
"build:health-payments": "cd packages/modules/health-payments && yarn build",
"build:health-hrms": "cd packages/modules/health-hrms && yarn build",
"build:microplan": "cd packages/modules/microplan && yarn build",
"deploy:jenkins": "./scripts/jenkins.sh",
"clean": "rm -rf node_modules"
Expand Down
4 changes: 3 additions & 1 deletion health/micro-ui/web/health-payments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
"node": ">=14"
},
"workspaces": [
"micro-ui-internals/packages/modules/health-payments"
"micro-ui-internals/packages/modules/health-payments",
"micro-ui-internals/packages/modules/health-hrms"
],
"homepage": "/payments-ui",
"dependencies": {
"@egovernments/digit-ui-module-health-hrms":"0.0.1",
"@egovernments/digit-ui-libraries": "1.8.8",
"@egovernments/digit-ui-module-core": "1.8.15",
"@egovernments/digit-ui-module-utilities": "1.0.1-beta.23",
Expand Down
1 change: 1 addition & 0 deletions health/micro-ui/web/micro-ui-internals/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"start": "react-scripts start"
},
"devDependencies": {
"@egovernments/digit-ui-module-health-payments": "0.1.0",
"@egovernments/digit-ui-module-health-hrms":"0.0.1",
"@egovernments/digit-ui-libraries": "1.8.17",
"@egovernments/digit-ui-module-workbench": "1.0.23",
Expand Down
Loading
Loading