New App Config wth dummy config for Form, Redux setup (Config, panel config, field config, localisation) setup initial commit #3242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||||||||||||||||||||||||||||||||||
| import { useTranslation } from "react-i18next"; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| import React, { Fragment, useEffect } from "react"; | ||||||||||||||||||||||||||||||||||||||||||
| import { EmployeeModuleCard } from "@egovernments/digit-ui-react-components"; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| const ROLES = { | ||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -27,9 +27,9 @@ const CampaignCard = () => { | |||||||||||||||||||||||||||||||||||||||||
| const { t } = useTranslation(); | ||||||||||||||||||||||||||||||||||||||||||
| const microplanStatus = "RESOURCE_ESTIMATIONS_APPROVED"; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| useEffect(() => { | ||||||||||||||||||||||||||||||||||||||||||
| sessionStorage.removeItem("HCM_SELECTED_TAB_INDEX"); | ||||||||||||||||||||||||||||||||||||||||||
| }, []); | ||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+30
to
+32
Contributor
There was a problem hiding this comment. Move useEffect above the early return. The useEffect hook is called after a conditional early return (line 24), violating React's Rules of Hooks. Hooks must be called unconditionally and in the same order on every render. When the employee lacks required roles, the component returns null before reaching the useEffect, breaking the hook calling order. Apply this diff to fix the hook placement: const CampaignCard = () => {
+ useEffect(() => {
+ sessionStorage.removeItem("HCM_SELECTED_TAB_INDEX");
+ }, []);
+
if (!Digit.Utils.didEmployeeHasAtleastOneRole(Object.values(ROLES).flatMap((e) => e))) {
return null;
}
const { t } = useTranslation();
const microplanStatus = "RESOURCE_ESTIMATIONS_APPROVED";
- useEffect(() => {
- sessionStorage.removeItem("HCM_SELECTED_TAB_INDEX");
- }, []);📝 Committable suggestion
Suggested change
🧰 Tools🪛 Biome (2.1.2)[error] 30-30: This hook is being called conditionally, but all hooks must be called in the exact same order in every component render. Hooks should not be called after an early return. For React to preserve state between calls, hooks needs to be called unconditionally and always in the same order. (lint/correctness/useHookAtTopLevel) 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| let links = [ | ||||||||||||||||||||||||||||||||||||||||||
| // { | ||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -55,6 +55,12 @@ const CampaignCard = () => { | |||||||||||||||||||||||||||||||||||||||||
| roles: ROLES.CAMPAIGN_MANAGER, | ||||||||||||||||||||||||||||||||||||||||||
| // count: isLoading?"-":data | ||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| label: t("NEW APP CONFIGURATION"), | ||||||||||||||||||||||||||||||||||||||||||
| link: `/${window?.contextPath}/employee/campaign/new-app-configuration-redesign?variant=app&masterName=FormConfig&fieldType=FieldTypeMappingConfig&prefix=CMP-2025-09-29-009540&localeModule=APPONE&tenantId=mz&campaignNumber=CMP-2025-09-29-009540&formId=default&projectType=Schisto`, | ||||||||||||||||||||||||||||||||||||||||||
| roles: ROLES.CAMPAIGN_MANAGER, | ||||||||||||||||||||||||||||||||||||||||||
| // count: isLoading?"-":data | ||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||
nabeelmd-eGov marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| label: t("ACTION_TEST_SETUP_CAMPAIGN_FROM_MICROPLAN"), | ||||||||||||||||||||||||||||||||||||||||||
| link: `/${window?.contextPath}/employee/campaign/setup-from-microplan?status=${microplanStatus}`, | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { FieldV1 } from "@egovernments/digit-ui-components"; | ||
| import React from "react"; | ||
| import { useTranslation } from "react-i18next"; | ||
| import { useSelector } from "react-redux"; | ||
|
|
||
| // Simple helper function to get field type | ||
| const getFieldType = (field, fieldTypeMasterData) => { | ||
| if (!fieldTypeMasterData || !Array.isArray(fieldTypeMasterData)) { | ||
| return "textInput"; | ||
| } | ||
|
|
||
| // Find matching field type based on type and format | ||
| const matched = fieldTypeMasterData.find((item) => item?.metadata?.type === field.type && item?.metadata?.format === field.format); | ||
|
|
||
| return matched?.fieldType || "textInput"; | ||
| }; | ||
nabeelmd-eGov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| const ComponentToRender = ({ field, t: customT, selectedField }) => { | ||
| const { byName } = useSelector((state) => state.fieldTypeMaster); | ||
| const { t } = useTranslation(); | ||
| console.log("responsePanelComponent", field, byName); | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // Get field type mapping from the field master data | ||
| const fieldTypeMasterData = byName?.FieldTypeMappingConfig || []; | ||
|
|
||
| // Get the field type | ||
| const fieldType = getFieldType(field, fieldTypeMasterData); | ||
|
|
||
| console.log("fieldType", fieldType); | ||
|
|
||
| return ( | ||
| <FieldV1 | ||
| charCount={field?.charCount} | ||
| config={{ | ||
| step: "", | ||
| }} | ||
| description={field?.isMdms ? t(field?.helpText) : field?.helpText || null} | ||
| error={field?.isMdms ? t(field?.errorMessage) : field?.errorMessage || null} | ||
| infoMessage={field?.isMdms ? t(field?.tooltip) : field?.tooltip || null} | ||
| label={field?.label} | ||
| onChange={function noRefCheck() {}} | ||
| placeholder={t(field?.innerLabel) || ""} | ||
nabeelmd-eGov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| populators={{ | ||
| t: field?.isMdms ? null : customT, | ||
| fieldPairClassName: `app-preview-field-pair ${ | ||
| selectedField?.jsonPath && selectedField?.jsonPath === field?.jsonPath | ||
| ? `app-preview-selected` | ||
| : selectedField?.id && selectedField?.id === field?.id | ||
| ? `app-preview-selected` | ||
| : `` | ||
| }`, | ||
| }} | ||
| required={getFieldType(field) === "custom" ? null : field?.["toArray.required"]} | ||
| type={fieldType} | ||
| value={field?.value === true ? "" : field?.value || ""} | ||
| disabled={field?.readOnly || false} | ||
nabeelmd-eGov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComponentToRender; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.