Bug fix for "code destruction due missing semicolon in commented lines" #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faced the same issue that was raised in this ticket:
#18
Fix will check all console statement lines to see if they end with a semi-colon and throw warning if they don't, with a message pointing to the location of the problem.
By default it doesn't fix the problem for you, just points you in the direction of the problem so you can fix your code.
If option 'forceProperLineEnd' is set to true though, it will add the semi-colon to the end of the line before continuing.
I've added tests for this, including some sample js files, so line breaks across OSs can be captured. Just having line breaks in strings wouldn't do this. I've tested OSX Maveriks and Windows 7 and 8.1 and they all pass tests, treating line breaks as the '\n' character. I have been stung by different linebreak characters before though, which is why I'm adding this test.
Also updated the README.md file with this option.