1962 ep cut for epi separation #1964
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| @@ -0,0 +1,56 @@ | |||
| #include <edm4eic/EDM4eicVersion.h> | |||
| #if EDM4EIC_VERSION_MAJOR >= 8 | |||
There was a problem hiding this comment.
No need to guard this for older versions. This is mostly done for features that require data model evolution. Here you are using standard functionality only.
| if (!assoc_opt) { | ||
| warning("[E/P Cut] no MC associations, skipping"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This makes it non-optional, so you should not mark is as std::optional in the header file.
| } | ||
|
|
||
| // true momentum and E/P | ||
| double ptrack = edm4hep::utils::magnitude(bestAssoc.getSim().getMomentum()); |
There was a problem hiding this comment.
This is using truth-level information in a non-transparent way. We should use the reconstructed momentum (see coincidentally #1960).
There was a problem hiding this comment.
Or we can use truth for now, but explicitly ingest the MCParticleCollection as input too.
|
|
||
| // true momentum and E/P | ||
| double ptrack = edm4hep::utils::magnitude(bestAssoc.getSim().getMomentum()); | ||
| double ep = (ptrack > 0 ? cluster.getEnergy() / ptrack : 0.0); |
There was a problem hiding this comment.
Where is the layer information used? This is using the full energy of the entire cluster, not the energy deposited up to a certain layer, as intended.
| // pull params from JANA: BEMCEoverPCut:ecut , BEMCEoverPCut:max_layer | ||
| double ecut_val = m_algo->getEcut(); // initial default | ||
| GetApplication()->GetParameter(GetPrefix() + ":ecut", ecut_val); | ||
| m_algo->setEcut(ecut_val); | ||
|
|
||
| int maxL = m_algo->getMaxLayer(); // initial default | ||
| GetApplication()->GetParameter(GetPrefix() + ":max_layer", maxL); | ||
| m_algo->setMaxLayer(maxL); |
There was a problem hiding this comment.
Better to leave this similar to the other factories, i.e. use ParameterRef instead of handling parameter setting by hand.
| const auto& [clusters_notnull, track_matches_notnull, hits_notnull] = input; | ||
| auto const& clusters = *clusters_notnull; | ||
| auto const& track_matches = *track_matches_notnull; | ||
| auto const& hits = *hits_notnull; |
There was a problem hiding this comment.
This is an unused variable and causes the compilation to fail in the checks.
…-separation' into 1962-ep-cut-for-epi-separation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| target_tensor.addToShape(2); // is electron, is hadron | ||
| target_tensor.setElementType(7); // 7 - int64 | ||
| std::vector<edm4eic::Cluster> sel_clusters; | ||
| if (!ep_pids) { |
There was a problem hiding this comment.
implicit conversion __tuple_element_t<2UL, tuple<not_null<const ClusterCollection *>, const MCRecoClusterParticleAssociationCollection *, const ParticleIDCollection *>> (aka const edm4hep::ParticleIDCollection *) -> bool
| if (!ep_pids) { | |
| if (ep_pids == nullptr) { |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Todo:
- move this file to github.com/eic/epic-data
- include as calibration artifact in github.com/eic/epic
| { | ||
| // FIXME: use track momentum once matching to tracks becomes available | ||
| edm4eic::MCRecoClusterParticleAssociation best_assoc; | ||
| for (auto assoc : *cluster_assocs) { |
There was a problem hiding this comment.
Dereference of null pointer
Briefly, what does this PR introduce?
This PR adds a new CalorimeterEoverPCut factory and algorithm to the BEMC reconstruction plugin. It computes an event‑by‑event E/p ratio for each barrel calorimeter cluster (using the highest‑weight MC association for true momentum), applies a JANA‑configurable threshold (ecut) and optional max_layer, and emits an edm4hep::ParticleIDCollection marking clusters that pass the cut as electrons. The factory will be registered in BEMC.cc under the EDM4EIC_VERSION_MAJOR >= 8 guard, mirroring the existing PreML/PostML pattern for EEMC.cc.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No breaking changes. Existing plugins and factories are unaffected.
Does this PR change default behavior?
No, no existing plugins or factories have been affected