Skip to content

Reapply "feat: inherit jana::components::JOmniFactory and transition to using upstream JOmniFactory (#1959)" #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reapply "feat: inherit jana::components::JOmniFactory and transition to using upstream JOmniFactory (#1959)" #2006

wants to merge 2 commits into from
+449 −1,826

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 8, 2025

Briefly, what does this PR introduce?

This reverts commit 69151c9.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@wdconinc
Reapply "feat: inherit jana::components::JOmniFactory and transition …
7e05eae 
…to using upstream JOmniFactory (#1959)"

This reverts commit 69151c9.
@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: far-backward Reconstruction related to far backward detectors topic: infrastructure topic: barrel topic: forward topic: backward labels Aug 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025 •
edited
Loading

Capybara summary for PR 2006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: far-backward Reconstruction related to far backward detectors topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wdconinc