Skip to content

Conversation

freee458
Copy link

I have added the part of code to convert edep and timing information to ADC and TDC.

Briefly, what does this PR introduce?

It is to digitize the hit information for Forward Time of Flight detector.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [true ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@github-actions github-actions bot added topic: PID Relates to PID reconstruction topic: forward labels Aug 28, 2025
@freee458 freee458 assigned freee458 and unassigned freee458 Aug 28, 2025
@freee458 freee458 requested review from simonge and wdconinc August 28, 2025 06:49
wdconinc added a commit that referenced this pull request Aug 28, 2025
This PR applies the include-what-you-use fixes as suggested by
https://github.com/eic/EICrecon/actions/runs/17288063235.
Please merge this PR into the branch `freee458-patch-1-1`
to resolve failures in PR #2053.

Auto-generated by [create-pull-request][1]

[1]: https://github.com/peter-evans/create-pull-request

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Honey Khindri <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
freee458 and others added 3 commits August 28, 2025 16:12
I have added the part of to convert edep and time information to ADC and TDC.
This PR applies the include-what-you-use fixes as suggested by
https://github.com/eic/EICrecon/actions/runs/17288063235.
Please merge this PR into the branch `freee458-patch-1-1`
to resolve failures in PR #2053.

Auto-generated by [create-pull-request][1]

[1]: https://github.com/peter-evans/create-pull-request

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Honey Khindri <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wdconinc wdconinc force-pushed the freee458-patch-1-1 branch from d3fcea6 to 1a7162c Compare August 28, 2025 21:12
@wdconinc
Copy link
Contributor

Rebased to pick up #2055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: forward topic: PID Relates to PID reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants