Automate beam energy configurations #886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We run some ci for every configuration and I think it may be based on the files in configurations/. Does that still work and does it blow up the CI load? |
simonge
force-pushed
the
Automate-beam-energy-configurations
branch
from
68354d4 to
c592377
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Aiming to address eic/EICrecon#1899 by automatically adding xml configurations for all beam energy combinations to detector setups which include far_forward or far_backward subsystems.
Also changes the default energy from 18x275 to 5x41 when no values are provided.
Some of the yml files probably don't need the far detector subsystems for the studies they are used for so could be removed.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Adds a lot more xml files to confuse the users.