Skip to content

Add a traceparent annotation to the TestRun created by v1alpha #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

I found no issue on this

Description of the Change

This traceparent shall be picked up by the testrun_controller and be added as an environment variable to be used in ETOS to link all traces together.

Alternate Designs

I thought about adding it to the spec instead, but having it in the annotations just felt right to me (and it makes for a much smaller change :))

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

This traceparent shall be picked up by the testrun_controller and
be added as an environment variable to be used in ETOS to link all
traces together.
@t-persson t-persson requested a review from a team as a code owner April 22, 2025 11:00
@t-persson t-persson requested review from fredjn and andmat900 and removed request for a team April 22, 2025 11:00
We don't need to select pods using the traceparent since it will
be different between all services. Better to have it as an annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant