Update the log listener to publish v2 events as well #84
Conversation
This is a backward compatibility change so that we may run SSE v1 and v2 at the same time, allowing us to test v2 more comprehensively
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
| try: | ||
| self.v2client.publish(self.identifier, parse(event)) | ||
| except: # pylint:disable=bare-except | ||
| # A catch-all exception here because if v2 publish fails, this |
There was a problem hiding this comment.
If v2 events suddenly stop getting published, we won't be able to see why. Is this correct?
Is there a risk that this function will be called endlessly?
There was a problem hiding this comment.
If v2 events suddenly stop getting published, we won't be able to see why. Is this correct?
I have added traceback.print_exc() locally that will be pushed, but no production release will be made using SSEv2 with the log listener. We'll still use v1 in production until all services publish v2.
Is there a risk that this function will be called endlessly?
Not anymore, since I added the bare except.
| @@ -69,7 +76,13 @@ def new_event(self, event: dict, _: Optional[str] = None) -> None: | |||
| """Get a new event from the internal RabbitMQ bus and write it to file.""" | |||
| if event.get("event") is None: | |||
| event = {"event": "message", "data": event} | |||
| self.__write(**event) | |||
| self.__write(event.get("event", ""), event.get("data", "")) | |||
There was a problem hiding this comment.
- If v2 event publishing fails, this
identifier()function will be called again. Then__write()will be executed twice?
There was a problem hiding this comment.
If v2 event publishing fails this function will not be called again since we catch all exceptions when publishing to v2.
Applicable Issues
Description of the Change
This is a backward compatibility change so that we may run SSE v1 and v2 at the same time, allowing us to test v2 more comprehensively
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]