Check the status of providers if they provide a status check endpoint #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
commented
Mar 24, 2025
andmat900
reviewed
Mar 24, 2025
| @@ -156,6 +203,12 @@ def _start(self, identifier: str) -> None: | |||
| if self.finished: | |||
| self.logger.info("ETOS test runner has finished", extra={"user_log": True}) | |||
| break | |||
| if not self._environment_active(): | |||
There was a problem hiding this comment.
Is there risk of a race condition during termination, when self.finished is still False, but self._environment_active() already returns False?
| @@ -156,6 +203,12 @@ def _start(self, identifier: str) -> None: | |||
| if self.finished: | |||
| self.logger.info("ETOS test runner has finished", extra={"user_log": True}) | |||
| break | |||
| if not self._environment_active(): | |||
| self.logger.error( | |||
There was a problem hiding this comment.
Should this be written to the OpenTelemetry span?
| """Make an HTTP request based on a request dictionary.""" | ||
| if request.get("auth"): | ||
| request["auth"] = self.__auth(**request["auth"]) | ||
| method = getattr(self.etos.http, request.pop("method").lower()) |
There was a problem hiding this comment.
Will it be robust enough if one failed check leads to termination? Even if there are retries.
| name, | ||
| request.get("url"), | ||
| ) | ||
| return False |
There was a problem hiding this comment.
Should an error like this return None, to indicate that health check was inconclusive? So that a few more retries could be done?
In other words, False should be returned only when we know for sure that the environment is inactive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
If a provider wants to provide a way for the ESR to check the status of the environment they provide then they can now set the 'status_request' key to a dictionary of the 'request' style. Similar to how the executor describes a request.
Any extra parameter allowed by the requests library is possible.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson <tobias.persson>