Close tab after the redirect to the external application.#146
Open
realARCHaim wants to merge 1 commit intoeinaregilsson:masterfrom
Open
Close tab after the redirect to the external application.#146realARCHaim wants to merge 1 commit intoeinaregilsson:masterfrom
realARCHaim wants to merge 1 commit intoeinaregilsson:masterfrom
Conversation
realARCHaim
force-pushed
the
khaimovmr/close-tab-on-external
branch
4 times, most recently
from
ead3742 to
f9c6866
Compare
Collaborator
|
Thanks. I'll look at this before I do the next release, not sure when that will be. :) |
realARCHaim
force-pushed
the
khaimovmr/close-tab-on-external
branch
2 times, most recently
from
959ae05 to
9527915
Compare
realARCHaim
force-pushed
the
khaimovmr/close-tab-on-external
branch
from
9527915 to
afdea12
Compare
realARCHaim
commented
May 8, 2019
| ignoreNextRequest[result.redirectTo] = new Date().getTime(); | ||
|
|
||
| if (result.redirectTo.match(internalProtocolsRegexp) == null) { | ||
| window.setTimeout(function(){chrome.tabs.remove(details.tabId);}, 5000); |
Author
There was a problem hiding this comment.
The timeout is for the case when the external application opens for a first time and awaits for the confirmation from user.
Ofcourse it affects only the external application calls done by redirect from the Redirector rules. Usual external protocols openings (like magnet:, skype:, etc) will not be affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.