feat: Copy with Redirect context menu#448
Open
brian6932 wants to merge 1 commit intoeinaregilsson:masterfrom
Open
feat: Copy with Redirect context menu#448brian6932 wants to merge 1 commit intoeinaregilsson:masterfrom
Copy with Redirect context menu#448brian6932 wants to merge 1 commit intoeinaregilsson:masterfrom
Conversation
|
Author
|
Yea, it's also under the cog without any extensions. |
7d227f9 to
38480aa
Compare
38480aa to
8c4d2c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This has no AI slop :),
the only issue's that if you check for matches when showing the context menu, it's a bit inconsistent to have it append. I'll see if I can improve that, I don't think I can hold the rendering of the context menu with a promise. Append?w=1to the diff to get a less crazy looking diff, there was a lot of trailing whitespace that my editor decided to trim.closes #443
closes #414
Challenges:
contextMenusAPI for this, it's a lot more basic than Firefox'smenus, so it's not possible to have match based contexts across browsers (e.g. https://issues.chromium.org/issues/40467152). It'd be cool iftargetUrlPatternsworked onlinktypes. As a workaround, I added a global toggle.