Skip to content

feat: Migrate to Manifest V3 and update background script to service …#453

Draft
mcallegario wants to merge 1 commit intoeinaregilsson:masterfrom
mcallegario:Manifest-V3-Support
Draft

feat: Migrate to Manifest V3 and update background script to service …#453
mcallegario wants to merge 1 commit intoeinaregilsson:masterfrom
mcallegario:Manifest-V3-Support

Conversation

@mcallegario
Copy link

…worker

  • Updated manifest version from 2 to 3 and adjusted permissions accordingly.
  • Changed background script to use service worker.
  • Implemented compatibility checks for Manifest V3 in redirector page.
  • Added theme detection scripts to handle dark/light mode changes.
  • Introduced favicon loader to ensure correct favicon display.
  • Refactored redirect loading logic to support both Manifest V2 and V3.
  • Added polyfill for Redirect class to maintain compatibility with service worker.
  • Removed deprecated browser action properties and updated to use action.
  • Enhanced error handling for theme detection and redirect loading.

…worker

- Updated manifest version from 2 to 3 and adjusted permissions accordingly.
- Changed background script to use service worker.
- Implemented compatibility checks for Manifest V3 in redirector page.
- Added theme detection scripts to handle dark/light mode changes.
- Introduced favicon loader to ensure correct favicon display.
- Refactored redirect loading logic to support both Manifest V2 and V3.
- Added polyfill for Redirect class to maintain compatibility with service worker.
- Removed deprecated browser action properties and updated to use action.
- Enhanced error handling for theme detection and redirect loading.
@Gitoffthelawn
Copy link
Collaborator

Wow. Thank you! ❤️ On which browser(s) and platform(s) have you tested this code?

@mcallegario mcallegario marked this pull request as draft August 5, 2025 05:03
@mcallegario
Copy link
Author

Wow. Thank you! ❤️ On which browser(s) and platform(s) have you tested this code?

I tested the latest version of Chrome and Edge installed on Windows 11

@Gitoffthelawn
Copy link
Collaborator

Wow. Thank you! ❤️ On which browser(s) and platform(s) have you tested this code?

I tested the latest version of Chrome and Edge installed on Windows 11

Thanks. Do you have time to test Firefox as well?

@parichay28
Copy link

Hello @mcallegario, just tried building the extension on mac & tried using in chrome. Looks like this doesn't work there (or perhaps I am doing something wrong). Will try testing on windows soon (currently don't have access to the PC)

@praveen7557
Copy link

I raised a PR #456 for the same, tested in Chrome, it works fine. @parichay28 can you test it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants