Support other env vars in CLI version#100
Open
mccahan wants to merge 2 commits intoeinaregilsson:masterfrom
Open
Support other env vars in CLI version#100mccahan wants to merge 2 commits intoeinaregilsson:masterfrom
mccahan wants to merge 2 commits intoeinaregilsson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While locally debugging another issue, I realized I couldn't define the existing bucket name and was hitting an AWS perms error. This functionality already exists, so I moved it outside the GitHub Action conditional so it can run everywhere and added some documentation to the README.