new-param-to-use-existing-file-on-s3#95
Open
mario16 wants to merge 11 commits intoeinaregilsson:masterfrom
Open
new-param-to-use-existing-file-on-s3#95mario16 wants to merge 11 commits intoeinaregilsson:masterfrom
mario16 wants to merge 11 commits intoeinaregilsson:masterfrom
Conversation
PabloGancharov
approved these changes
Nov 21, 2022
Contributor
|
I'm not a 100% sure what you are trying to accomplish here. The blast radius is such that reviewing this for correctness is a bit hard. If I understand correctly, you wish to deploy an existing archive - where would this archive originate from? I'm not sure how relevant that kind of functionality is for this Github Action, since it would reduce the transparency of any run since what was deployed would not be immediately obvious from the triggering Git SHA. |
Update beanstalk-deploy.js
…nt-default-as-true feature/set-flag-wait-for-deployment-default-as-true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contribution is to add a new param named "existing_file_name" to use an existing s3 file and avoid to upload a new file.
This change is to get the "build once, deploy many".
Trying to follow the "12 factor app", principle "V. Build, Release, Run".
More info: 12 factor app