Skip to content

feat(onboarding): one onboarding list at a time — checklist owns activation, StartHereCard owns first five - #252

Merged
ejay-dev merged 1 commit into
mainfrom
feat/first-session-onboarding-consolidation
Jun 12, 2026
Merged

feat(onboarding): one onboarding list at a time — checklist owns activation, StartHereCard owns first five#252
ejay-dev merged 1 commit into
mainfrom
feat/first-session-onboarding-consolidation

Conversation

@ejay-dev

Copy link
Copy Markdown
Owner

Summary

Surface 2 of the first-session density workstream (dashboard: #250, compliance: #251). A new user could see up to three competing onboarding lists at once. This PR differentiates them along the agreed split — StartHereCard = first 5 actions, checklist = full activation milestones — and makes sure only one is ever on screen:

  • Readiness tab (CommandCenter): drop the 4-phase Activation Progress card. Its summary numbers (milestones done, progress %) already render in the KPI bar immediately above it, and the checklist below it tracks the same arc at finer grain. The milestone computation stays — the KPI bar and the Readiness tab badge still use it.
  • GettingStartedChecklist: generic variant retitled from "Getting Started / Your first wins in FormaOS" to "Activation / Activation milestones", so it reads as the long-arc list rather than a second first-steps guide. The industry variant already said "Activation Roadmap".
  • Employee dashboard: the checklist is suppressed while StartHereCard renders above it (new firstSessionActive prop from DashboardWrapper — the same prop pattern feat(dashboard): focused first-session view — guide + live tiles only #250 introduced for CommandCenter; hunks are disjoint, so the two PRs merge cleanly in either order).

Net: −83 lines, one whole block removed from the Readiness tab, and no screen ever shows two onboarding lists.

Verification

  • npm run typecheck — pass
  • npx eslint on all four touched files — clean (now-unused ArrowRight/TrendingUp/DashboardSectionCard/cn imports removed)
  • npx jest tests/dashboard/dashboard-wrapper.test.tsx — 2/2 pass
  • e2e/onboarding-flow.spec.ts asserts only start-here-*, onboarding-*, and post-onboarding-* testids — none of the removed/renamed UI; no e2e or unit test references "Activation Progress", the old checklist title, or getting-started-checklist internals

https://claude.ai/code/session_01TyMddHGjcjofqS6K9H2MeW


Generated by Claude Code

…vation, StartHereCard owns first five

A new user could see up to three competing onboarding lists at once:
StartHereCard (first 5 guided actions) stacked above the employee
dashboard's GettingStartedChecklist, and on the Readiness tab the
4-phase Activation Progress card stacked directly on the checklist
that tracks the same milestones at finer grain.

- Readiness tab: drop the Activation Progress card. Its summary
  numbers (milestones done, progress %) already render in the KPI bar
  immediately above, and the checklist is the canonical milestone
  list. The milestone computation stays — KPI bar and tab badge use it.
- GettingStartedChecklist: retitle the generic variant from 'Getting
  Started / Your first wins in FormaOS' to 'Activation / Activation
  milestones' so it reads as the long-arc list, not a second
  first-steps guide. Industry variant already says Activation Roadmap.
- Employee dashboard: suppress the checklist while StartHereCard is
  on screen (new firstSessionActive prop passed from DashboardWrapper,
  same pattern as the command-center prop in PR #250).

No new primitives; deletes one block and removes now-unused imports.
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forma-os Ready Ready Preview, Comment Jun 12, 2026 4:25pm

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ejay-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 9 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 301a554f-9941-42ac-81fc-59ac3808bee0

📥 Commits

Reviewing files that changed from the base of the PR and between 19107fb and 53ddb46.

📒 Files selected for processing (4)
  • app/app/dashboard-wrapper.tsx
  • components/dashboard/command-center.tsx
  • components/dashboard/employee-dashboard.tsx
  • components/onboarding/GettingStartedChecklist.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/first-session-onboarding-consolidation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

♿ Accessibility Test Results

PASSED - No critical accessibility issues found

Tests Performed:

  • WCAG 2.1 AA compliance validation
  • Cross-browser accessibility testing
  • Keyboard navigation testing
  • Screen reader compatibility
  • Color contrast validation

Artifacts: Download the accessibility reports from the "Artifacts" section for detailed results.

@ejay-dev
ejay-dev merged commit 31a6105 into main Jun 12, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants