Skip to content

docs(audit): record Phase C batch-1 PR refs + #108 verification #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejay-dev merged 1 commit into from
May 13, 2026
Merged

docs(audit): record Phase C batch-1 PR refs + #108 verification #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/audit/2026-05-12-deep-audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Verified-fine on direct inspection (rejected from this audit):
|---|------|---------|-----------|----|
| 4 | HIGH | Marketing contact form: server action emits structured error codes (`rate_limit`, `invalid_email`, `1`) but UI maps them all to a single "Something went wrong" message. User cannot tell rate-limit from validation from server error. | `app/(marketing)/contact/ContactPageContentNew.tsx:681-692` vs `app/(marketing)/contact/actions.ts:29,53,58,85` | #50 |
| 5 | MED | `app/app/settings/email-preferences/page.tsx:185` does `if (error) throw error;` inside a handler — re-scoped on inspection: the try/catch does swallow the throw; the real bug is the generic "Failed to save preferences" pill showing for every error mode. Now appends the actual `error.message` to the user-facing pill, truncated. | `app/app/settings/email-preferences/page.tsx:183-200` | #63 |
| 6 | MED | `app/admin/components/add-note-form.tsx:44` calls `window.location.reload()` after a successful note insert. Destroys all client state and flashes a full reload. Should optimistic-add + toast. | `app/admin/components/add-note-form.tsx:31-50` | — |
| 6 | MED | `app/admin/components/add-note-form.tsx:44` calls `window.location.reload()` after a successful note insert. Destroys all client state and flashes a full reload. Should optimistic-add + toast. Re-scoped to Option B per session guidance: `router.refresh()` + existing compliance-toast primitive extended with `duration: 0` opt-out so the error toast stays sticky until the admin manually dismisses it. | `app/admin/components/add-note-form.tsx:31-50` | #66 |
| 7 | MED | MFA challenge form fallback error is "We could not verify that code. Please try again." for every failure mode (expired token, network, rate-limit). Server side has the codes; UI doesn't surface them. Switch now covers all six route codes (rate_limited, invalid_token, invalid_token_format, invalid_body, unauthorized, mfa_verify_failed). | `app/auth/mfa-challenge/MfaChallengeForm.tsx:34-95` | #64 |
| 8 | LOW | `app/join/page.tsx:80-103` catches everything with "An unexpected error occurred." The `/api/auth/bootstrap` call returns useful error bodies that aren't surfaced. | `app/join/page.tsx:80-103` | — |

Expand Down
Loading
Loading