Skip to content

fix(marketing): align /features hero count + categories with the data source - #79

Merged
ejay-dev merged 1 commit into
mainfrom
fix/features-arithmetic
May 13, 2026
Merged

fix(marketing): align /features hero count + categories with the data source#79
ejay-dev merged 1 commit into
mainfrom
fix/features-arithmetic

Conversation

@ejay-dev

Copy link
Copy Markdown
Owner

Summary

Closes marketing-audit row #6 (HIGH, §3 cross-cutting). Three visible numbers on /features disagreed with the actual data:

Surface Stated Audit reality
Hero subtitle "18 features across compliance, automation, security, and collaboration" (4 cats) 25 features / 5 cats
Secondary subtitle "18 platform features across four categories" 25 / 5
Page metadata description "23 core features ... 5 categories" 25 / 5

Verification

Counted directly against the features array in FeaturesPageContent.tsx:

Category Count
Compliance Core 5
Workflow & Operations 6
Identity & Security 4
Collaboration & UX 7
AI & Certification 3
Total 25

Both the hero "18 / four categories" and the metadata "23 core features" were stale.

What changed

Prose alignment in FeaturesPageContent.tsx (hero + secondary subtitle) and page.tsx (metadata description for OG + Twitter). No DOM-arithmetic change required — the per-card category counts were already computed dynamically via features.filter(...).length and were correct; only the surrounding copy was off.

Test plan

  • tsc --noEmit -p tsconfig.typecheck.json — clean.
  • eslint on both touched files — clean.
  • Post-merge: hero reads "25 features across compliance, workflow, identity, collaboration, and AI"; per-category counts (5/6/4/7/3) match.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

… source

Closes marketing-audit row #6 (HIGH, §3 cross-cutting). Three
visible numbers on /features disagreed with the actual data:

  Hero subtitle:        "18 features across compliance, automation,
                         security, and collaboration"  (4 cats)
  Secondary subtitle:   "18 platform features across four
                         categories"
  Page metadata copy:   "23 core features across ... 5 categories"

Verified against the `features` array in FeaturesPageContent.tsx:
**25 entries spread across 5 categories** (Compliance Core 5,
Workflow & Operations 6, Identity & Security 4, Collaboration &
UX 7, AI & Certification 3). Both the hero "18 features / four
categories" and the metadata "23 core features" were stale.

Fix: align all three strings to "25 features across five
categories" with category labels matching the actual `categories`
array. No DOM-arithmetic change required — the per-card counts
were already computed via `features.filter(...).length` and were
correct; only the prose copy disagreed.

Updated text:

  Hero:       "25 features across compliance, workflow, identity,
              collaboration, and AI"
  Secondary:  "25 platform features across five categories"
  Metadata:   "Explore 25 core features across compliance
              operations, workflow automation, identity & security,
              collaboration, and AI & certification."

Verified:
  - tsc --noEmit -p tsconfig.typecheck.json: clean
  - eslint on both touched files: clean

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 13, 2026 06:32
@vercel

vercel Bot commented May 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forma-os Ready Ready Preview, Comment May 13, 2026 6:35am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ae6e3c25c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1968 to +1969
25 features across compliance, workflow, identity, collaboration,
and AI — built for regulated teams that need provable control over

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the stats bar count too

When /features renders after this change, the hero and grid intro now say there are 25 features, but the same page still renders platformStats with 23 for “Platform Features” (line 675, shown through StatsSection at line 2052). Users scrolling from the hero into “The platform at a glance” will still see conflicting feature totals, so the visible count remains only partially aligned with the 25-item data source.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the /features marketing page copy so the displayed feature totals and category count match the actual features data source in FeaturesPageContent.tsx.

Changes:

  • Updated OpenGraph/Twitter metadata descriptions from “23 core features” to “25 core features” and refreshed the category list.
  • Updated the hero subtitle to reflect “25 features” and five categories (matching the in-file features array).
  • Updated the secondary subtitle from “18 … four categories” to “25 … five categories”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/(marketing)/features/page.tsx Aligns OG/Twitter metadata description counts/categories with the features data source.
app/(marketing)/features/FeaturesPageContent.tsx Aligns on-page hero + secondary subtitle copy with the 25-feature / 5-category dataset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

♿ Accessibility Test Results

PASSED - No critical accessibility issues found

Tests Performed:

  • WCAG 2.1 AA compliance validation
  • Cross-browser accessibility testing
  • Keyboard navigation testing
  • Screen reader compatibility
  • Color contrast validation

Artifacts: Download the accessibility reports from the "Artifacts" section for detailed results.

@ejay-dev
ejay-dev merged commit c734f8d into main May 13, 2026
33 checks passed
@ejay-dev
ejay-dev deleted the fix/features-arithmetic branch May 13, 2026 06:49
ejay-dev added a commit that referenced this pull request May 13, 2026
…ups (#85)

Cadence rollup for the Phase C HIGH batch 2 round. No code/runtime
changes — audit-doc only.

Updates:
- Rows #4, #5, #6, #8 (§3 cross-cutting HIGHs): annotate Shipped in
  #81, #80, #79, #82 with the actual approach taken on each.
- Row #16 (MED, JSON-LD personal twitter handle): Shipped in #78.
- §20c (industry-page portal opt-out): 5 of 10 missing entries
  marked Resolved by #83 as intentional design call; the
  comment block in lib/marketing/background-media.ts is now the
  source of truth.
- §20d (oversized portal JPEGs): record what #84 actually shipped
  (3 portrait recompresses) and what it didn't (4 landscapes that
  re-encoded larger). Lesson captured: aspirational ≤180 KB target
  only applies when the source is over-dimensioned.
- New §19a section indexing the batch 2 PR list (#77-#84) and
  explicitly recording the severity-ordering self-catch where
  #78 (MED) shipped before §3 HIGHs, with course-correction.

Co-authored-by: ejaz <ejaz@local>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants