Better argument parsing #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `gh-md-toc` will only do a limited job parsing arguments. e.g. `gh-md-toc --insert --hide-footer --skip-header README.md` would fail as only the `--insert` option would be parsed as an option and the `--hide-footer` option would be considered the filename. This PR adds a new parser in a loop that will parse all arguments instead. The parser is inspired by https://stackoverflow.com/a/14203146, which solves the problem nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
gh-md-tocwill only do a limited job parsing arguments.e.g.
gh-md-toc --insert --hide-footer --skip-header README.mdwould fail as only the--insertoption would be parsed as an option and the--hide-footeroption would be considered the filename.This PR adds a new parser in a loop that will parse all arguments instead.
The parser is inspired by https://stackoverflow.com/a/14203146, which solves the problem nicely.