Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tags): add tags property to more resources #560

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

apgrucza
Copy link
Contributor

@apgrucza apgrucza commented Feb 8, 2025

Added tags to these resources:

  • ApplicationAutoScalingScalableTarget
  • CloudTrailTrail
  • FirehoseDeliveryStream
  • ResourceExplorer2Index
  • ResourceExplorer2View
  • SSMDocument

Copy link
Owner

@ekristen ekristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apgrucza -- I made a comment on a single one, it's going to have to be done on all.

resources/applicationautoscaling-scalable-targets.go Outdated Show resolved Hide resolved
@apgrucza apgrucza force-pushed the add-tags-to-resources branch from 8f12ba7 to d065d19 Compare February 8, 2025 23:21
@apgrucza apgrucza requested a review from ekristen February 8, 2025 23:23
@ekristen
Copy link
Owner

Thanks. I'm prepping a couple PRs for merge, this will merge but won't immediately release.

@ekristen ekristen merged commit 1783db0 into ekristen:main Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants