feat: add support for UpgradePolicy attribute in cluster creation #8534
+151
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guessi
force-pushed
the
feature/upgrade-policy-support
branch
2 times, most recently
from
b00f0d6 to
6927aa3
Compare
guessi
force-pushed
the
feature/upgrade-policy-support
branch
2 times, most recently
from
ae878d6 to
e04f40b
Compare
|
@NicholasBlaskey Just made an update to address issues that you pointed out - e04f40b thanks ! |
guessi
force-pushed
the
feature/upgrade-policy-support
branch
from
6cf02eb to
a6c8769
Compare
| # UpgradePolicy allows you to specify the support type for your cluster | ||
| # Valid values are "STANDARD" and "EXTENDED (default)" | ||
| # - https://docs.aws.amazon.com/eks/latest/APIReference/API_UpgradePolicyRequest.html | ||
| upgradePolicy: |
There was a problem hiding this comment.
Could we move upgradePolicy outside of metadata and put it as a top level field?
There was a problem hiding this comment.
@NicholasBlaskey thanks for your review, I simplified the sample config - 3ba2905 please review again, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UpgradePolicy attribute during cluster creation, allowing users to specify support type (STANDARD or EXTENDED) for EKS clusters.
Resolves #7932