-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Documentation restructure #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some quick suggestions for the intro doc, since you asked for it. I haven't done a full review. Let me know when you want one.
Fantastic, thank you! Still some work to do, so I probably won't open this up for a full review until tomorrow. I'll let you know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qard this is ready for a final review
It looks like it doesn't like the commit naming from the GitHub suggestions: |
172745b
to
ec2e2de
Compare
Yes, all commits need to follow the |
c835086
to
1e5f4ba
Compare
Co-Authored-By: Stephen Belanger <[email protected]>
Co-Authored-By: Stephen Belanger <[email protected]>
1e5f4ba
to
aee9d64
Compare
Finally got this green @Qard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one formatting question. Also, I'd like to backport this to 2.x so we can minimize the delta between versions allowing future doc fixes to be backported easily too. Any issues you foresee with that?
I agree with backporting these changes. I expect a few collisions, but don't see any major problems getting this backported. |
# Conflicts: # docs/redirects.asciidoc
WIP. For #1427.
This PR accomplishes the following:
New layout (only one link changes)
