Replace nokogiri with jsoup #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nokogiri doesn't have HTML5 support for its jruby version. Luckily jruby has access to java libs, so we can get this support by using jsoup.
Jsoup and nokogiri have a mostly identical implementation of HTML extraction. Mostly it was enough to just use the correct jsoup method name.
However, nokogiri had an agnostic
searchmethod that would take either a CSS or XPath selector. Instead of this, jsoup has two different methods for either case. Because of this, some refactoring around extraction rule selectors was necessary.Changes
Release Note
Open Crawler now supports crawling HTML5 web content.