-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FN Tuning] Shared Object Created or Changed by Previously Unknown Pr… #4529
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
⛔️ Tests failed: |
"systemd" or "root" or "sshd" or "pip" or "jlink" or python* or "update-alternatives" or pip* or | ||
"installer.bin.inst" or "uninstall-bin" or "linux_agent.inst" or crio or ssm-agent-worker or packagekitd | ||
"systemd" or "root" or "sshd" or "pip" or "jlink" or python* or "update-alternatives" or pip* or "crio" or | ||
"ssm-agent-worker" or "packagekitd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we see if the SSM agent is created the SO because it's running a custom document? If so, this would be very suspicious IMO. AWS-managed SSM docs may do things on Linux systems as a requirement for managing these nodes, however, custom SSM docs can be abused to run whatever on that EC2 instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we just have the file creation event, so all I have is a process name and file path. The file path for this FP pattern is: /usr/lib/jvm/java-17-openjdk-17.0.14.0.7-3.el8.x86_64/lib/{file}.so
.
As the pattern is easy to exclude based on process/path, I added the following exclusion (process.name:"ssm-agent-worker" and file.path:/usr/lib/jvm/java*)
rather than just on process.name. Thanks for the review @terrancedejesus !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
⛔️ Tests failed:
|
⛔️ Tests failed:
|
⛔️ Tests failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Manual review, looks good to me! 👍
⛔️ Test failed Results
|
⛔️ Test failed Results
|
⛔️ Test failed Results
|
Summary
Updating this rule to detect more paths that store shared objects + adding coverage for shared objects that leverage the
.so.$int
naming format such asso.2
, as this was currently not detected.